Final: mo_sethet
#373
Merged
Final: mo_sethet
#373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… first switch from ThreadVectorRange to TeamVectorRange; remove unneeded initialization. Remove team and parallelism from gas_washout.
Closed
Collaborator
Author
|
Thanks @odiazib ! Finally ready for a review & merge 😄 |
jaelynlitz
requested review from
jeff-cohere,
mjs271,
overfelt and
singhbalwinder
odiazib
approved these changes
Nov 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #373 +/- ##
==========================================
- Coverage 95.92% 95.87% -0.05%
==========================================
Files 45 45
Lines 9172 9306 +134
==========================================
+ Hits 8798 8922 +124
- Misses 374 384 +10 ☔ View full report in Codecov by Sentry. |
jeff-cohere
reviewed
Nov 8, 2024
jeff-cohere
reviewed
Nov 8, 2024
jeff-cohere
approved these changes
Nov 8, 2024
Collaborator
jeff-cohere
left a comment
jeff-cohere
left a comment
There was a problem hiding this comment.
I left a couple of comments. Thanks for replacing the other PR with this one, @jaelynlitz .
singhbalwinder
approved these changes
Nov 8, 2024
Contributor
singhbalwinder
left a comment
singhbalwinder
left a comment
There was a problem hiding this comment.
Thanks for your hard work and getting it to the finish line!
overfelt
reviewed
Nov 8, 2024
overfelt
approved these changes
Nov 8, 2024
mjs271
pushed a commit
that referenced
this pull request
Dec 21, 2024
* convert fortran of sethet to c++ * use pcnst value from modal_aer_opt * polish sethet * compile * add parameters * fix parens * remove extra const * fix includes * code compiles and test runs (and fails) * change gas_pcnst and tolerance * format * add comments * fix gas_washout, indexing issues in sethet * format * fix indexes and validation * remove kokkos for from gas_washout * format and cleanup * remove changes in mo_chm_diags * cleanup var name [skip-ci] * cleanup * add barrier to stop intermittent race condition(?) * add more parallelism in sethet and calc_precip_rescale * format * cleanup * fix compile errors * change loops to vector ranges * change tolerance * format * add additional parallel fors * format * add parallel reduces to calc_precip_rescale * Starting from the commit where tests are passing on GPUs and CPUs, we first switch from ThreadVectorRange to TeamVectorRange; remove unneeded initialization. Remove team and parallelism from gas_washout. * Fix compilation error in CUDA. * Remove parallel_for to fix CUDA sethet test. * Remove team_barriers and combine parallels. * Clang format. * address review comments and format * address bugs from reviews --------- Co-authored-by: Oscar Diaz-Ibarra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opened to take over #295 to have a clean starting point to debug from