Skip to content

Conversation

@odiazib
Copy link
Contributor

@odiazib odiazib commented May 10, 2025

Fixing the 524 - validate_gas_washout_merged (Failed) and 492 - validate_chm_diags_ts_355 (Failed) tests in Frontier.

@codecov
Copy link

codecov bot commented May 10, 2025

Codecov Report

Attention: Patch coverage is 61.53846% with 30 lines in your changes missing coverage. Please review.

Project coverage is 93.45%. Comparing base (60c6c3c) to head (9ae3393).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/mam4xx/mo_chm_diags.hpp 59.45% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #442      +/-   ##
==========================================
+ Coverage   93.43%   93.45%   +0.01%     
==========================================
  Files         303      303              
  Lines       25160    25180      +20     
  Branches     2786     2763      -23     
==========================================
+ Hits        23509    23531      +22     
+ Misses       1651     1649       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@odiazib odiazib marked this pull request as ready for review May 12, 2025 14:50
@odiazib
Copy link
Contributor Author

odiazib commented May 16, 2025

@singhbalwinder @jaelynlitz @mjschmidt271 , can we merge this PR? Most of these changes will not affect eamxx. Please see this PR: E3SM-Project/E3SM#7335.

Copy link
Collaborator

@mjschmidt271 mjschmidt271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@singhbalwinder singhbalwinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! thanks @odiazib !

@odiazib odiazib force-pushed the oscar/gas_washout_test branch from fc9f8a9 to a11efdc Compare May 16, 2025 16:33
@odiazib
Copy link
Contributor Author

odiazib commented May 16, 2025

@mjschmidt271 @jeff-cohere
The AT is encountering this error in the CUDA build.

/home/runner/_work/mam4xx/mam4xx/haero_install/include/kokkos/Cuda/Kokkos_Cuda_Half_Conversion.hpp(415): error: identifier "__ll2bfloat16_rn" is undefined
  bhalf_t cast_to_bhalf(long long val) { return __ll2bfloat16_rn(val); }

Do you have any thoughts on this?

@jeff-cohere
Copy link
Collaborator

When I've encountered errors like this in the past, it has sometimes been due to a mis- or un-specified CUDA architecture or an incorrect version of the library. I'm not able to dig up anything more specific than that at the moment.

@mjschmidt271
Copy link
Collaborator

@mjschmidt271 @jeff-cohere The AT is encountering this error in the CUDA build.

/home/runner/_work/mam4xx/mam4xx/haero_install/include/kokkos/Cuda/Kokkos_Cuda_Half_Conversion.hpp(415): error: identifier "__ll2bfloat16_rn" is undefined
  bhalf_t cast_to_bhalf(long long val) { return __ll2bfloat16_rn(val); }

Do you have any thoughts on this?

I know I've urn into the same before--let me give it a look!

@odiazib
Copy link
Contributor Author

odiazib commented May 16, 2025

One note: I also see this error in my other PR: #444. I believe this error is happening after the latest merge in haero.

@odiazib odiazib force-pushed the oscar/gas_washout_test branch from a11efdc to 9ae3393 Compare May 27, 2025 21:28
@odiazib
Copy link
Contributor Author

odiazib commented May 27, 2025

@singhbalwinder @jeff-cohere can we merge this PR?

@singhbalwinder singhbalwinder merged commit 4390a78 into main May 28, 2025
14 checks passed
@singhbalwinder singhbalwinder deleted the oscar/gas_washout_test branch May 28, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants