-
Notifications
You must be signed in to change notification settings - Fork 8
Fixing gas washout test for Frontier. #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
+ Coverage 93.43% 93.45% +0.01%
==========================================
Files 303 303
Lines 25160 25180 +20
Branches 2786 2763 -23
==========================================
+ Hits 23509 23531 +22
+ Misses 1651 1649 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@singhbalwinder @jaelynlitz @mjschmidt271 , can we merge this PR? Most of these changes will not affect eamxx. Please see this PR: E3SM-Project/E3SM#7335. |
mjschmidt271
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
singhbalwinder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! thanks @odiazib !
fc9f8a9 to
a11efdc
Compare
|
@mjschmidt271 @jeff-cohere Do you have any thoughts on this? |
|
When I've encountered errors like this in the past, it has sometimes been due to a mis- or un-specified CUDA architecture or an incorrect version of the library. I'm not able to dig up anything more specific than that at the moment. |
I know I've urn into the same before--let me give it a look! |
|
One note: I also see this error in my other PR: #444. I believe this error is happening after the latest merge in haero. |
a11efdc to
9ae3393
Compare
|
@singhbalwinder @jeff-cohere can we merge this PR? |
Fixing the
524 - validate_gas_washout_merged (Failed)and492 - validate_chm_diags_ts_355 (Failed)tests in Frontier.