Expose the activation fractions to make them settable from E3SM. #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
=======================================
Coverage 93.42% 93.43%
=======================================
Files 303 303
Lines 25171 25177 +6
Branches 2766 2766
=======================================
+ Hits 23517 23523 +6
Misses 1654 1654 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
overfelt
force-pushed
the
overfelt/make_activation_fractions_input_values
branch
from
27e2825 to
c381b9b
Compare
Yet another change to a function signature in order to be able to set these values form the E3SM input.
overfelt
force-pushed
the
overfelt/make_activation_fractions_input_values
branch
from
c381b9b to
1aba6b4
Compare
singhbalwinder
approved these changes
Sep 25, 2025
Contributor
singhbalwinder
left a comment
singhbalwinder
left a comment
There was a problem hiding this comment.
Looks good. Thanks, @overfelt !
overfelt
deleted the
overfelt/make_activation_fractions_input_values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another change to a function signature in order to be able to set these values form the E3SM input.