fixed: AudioGeneratorMP3 reads uninitialized memory on first iteration#522
Closed
RomanLut wants to merge 3 commits intoearlephilhower:masterfrom
Closed
fixed: AudioGeneratorMP3 reads uninitialized memory on first iteration#522RomanLut wants to merge 3 commits intoearlephilhower:masterfrom
RomanLut wants to merge 3 commits intoearlephilhower:masterfrom
Conversation
Owner
|
Thanks for the contribution but going through the logic, it doesn't seem to be right. I also run the MP3 decode through |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the first iteration, AudioGeneratorMP3 is reading synth->pcm.samples[0][samplePtr] array which is not initialized.
May cause Pop sound due to garbage in array.