Speed up MIDI by 20% on Pico with faster SADD#791
Closed
earlephilhower wants to merge 1 commit intomasterfrom
Closed
Speed up MIDI by 20% on Pico with faster SADD#791earlephilhower wants to merge 1 commit intomasterfrom
earlephilhower wants to merge 1 commit intomasterfrom
Conversation
Rewrite the saturation detection in the MIDI inner loop to give a 20%(!) boost in performance on the Pico RP2040
Owner
Author
|
D'oh! 😱 Off by 1 error, the patch was effectively never clipping. Need to look at bits 30...15, not 31...16 to detect carry in ~= carry out. When adjusted to work properly, back to same performance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrite the saturation detection in the MIDI inner loop to give a 20%(!) boost in performance on the Pico RP2040