Call i2s_channel_enable(_tx_handle) in AudioOutputSPDIF::begin()#799
Merged
earlephilhower merged 1 commit intoearlephilhower:masterfrom Nov 12, 2025
Merged
Call i2s_channel_enable(_tx_handle) in AudioOutputSPDIF::begin()#799earlephilhower merged 1 commit intoearlephilhower:masterfrom
earlephilhower merged 1 commit intoearlephilhower:masterfrom
Conversation
i2s_channel_enable(_tx_handle) was only called within AudioOutputSPDIF::SetRate(), which caused i2s_channel_write to fail if the rate was the same with the default 44100Hz. This fixes the issue by calling it in begin().
earlephilhower
approved these changes
Nov 12, 2025
Owner
earlephilhower
left a comment
earlephilhower
left a comment
There was a problem hiding this comment.
Thanks! I tested what I could when I moved to the IDF 5.x, but looks like I missed this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
i2s_channel_enable(_tx_handle)is only called within AudioOutputSPDIF::SetRate(), which caused i2s_channel_write() to fail with the following error when the source rate is accidentally the same with the default 44100Hz.This fixes the issue by enabling the i2s channel in AudioOutputSPDIF::begin().