Conversation
paraseba
reviewed
Jun 24, 2025
icechunk/src/repository.rs
Outdated
| Ok(session) | ||
| } | ||
|
|
||
| pub async fn rewrite_manifests( |
Collaborator
There was a problem hiding this comment.
Other options for consideration: optimize_manifests, reshard_manifests
dcherian
changed the title
rewrite_manifests EAER-1667rewrite_manifests EAR-1667
dcherian
force-pushed
the
empty-commits
branch
4 times, most recently
from
4bbf424 to
e285309
Compare
dcherian
commented
Jun 24, 2025
dcherian
commented
Jun 24, 2025
dcherian
force-pushed
the
empty-commits
branch
3 times, most recently
from
97209a1 to
80b5b28
Compare
paraseba
reviewed
Jun 24, 2025
| self.store = self.repo.writable_session("main").store | ||
|
|
||
| @precondition(lambda self: not self.store.session.has_uncommitted_changes) | ||
| @rule(data=st.data()) |
paraseba
approved these changes
Jun 26, 2025
Collaborator
paraseba
left a comment
paraseba
left a comment
There was a problem hiding this comment.
Do we need a test to prove ourselves that manifest can also be fused back into fewer ones by calling rewrite_manifests? Or are covered?
Collaborator
Author
That's covered. For completeness, I just added one for the case where we split existing multiple manifests in to smaller manifests too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #986
Updated docs here: https://icechunk--1002.org.readthedocs.build/en/1002/icechunk-python/performance/#splitting-manifests
Questions:
metadata? and make sure it's easy to use for creating a new repo?Decisions: