Improve performance of GC and stats for repos with multiple refs#1078
Merged
Improve performance of GC and stats for repos with multiple refs#1078
Conversation
This avoids repeating computation (and I/O) when multiple branches/tags repeat parts of the tree (true in almost any repo that has more than one branch/tag)
dcherian
reviewed
Jul 15, 2025
dcherian
approved these changes
Jul 15, 2025
dcherian
reviewed
Jul 15, 2025
| .err_into::<RepositoryError>(); | ||
| pin!(roots); | ||
|
|
||
| while let Some(pointed_snap_id) = roots.try_next().await? { |
Collaborator
There was a problem hiding this comment.
How big a drag is this loop? Does it make sense to concurrently iterate over roots instead?
EDIT: I guess it's slow since we are pulling new snapshots for ancestry
Collaborator
Author
There was a problem hiding this comment.
yes, there are a few optimizations we need to do here ... it's not totally trivial because we always need to keep track of things we have already seen, so there is mutable state across the threads. But totally doable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids repeating computation (and I/O) when multiple branches/tags repeat parts of the tree (true in almost any repo that has more than one branch/tag)