Conversation
paraseba
force-pushed
the
push-utulkwwkkqny
branch
2 times, most recently
from
23d9760 to
25483b0
Compare
This adds concurrency to `repo_chunks_storage`. I verified manually this improves performance very significantly, but benchmarks should be able to tell us.
paraseba
force-pushed
the
push-utulkwwkkqny
branch
from
25483b0 to
f218cd5
Compare
mpiannucci
approved these changes
Jul 15, 2025
| ) | ||
| .await | ||
| }) | ||
| .try_buffered(process_manifests_concurrently.get() as usize) |
Collaborator
There was a problem hiding this comment.
Yesss!! I was hoping it would be structured instead of spawning!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds concurrency to
repo_chunks_storage.I verified manually this improves performance very significantly, but benchmarks should be able to tell us.