Add snapshot id to NewCommitUpdate repo change#1581
Merged
Conversation
This is an Icechunk 2 on-disk format breaking change. Closes: #1580
mpiannucci
approved these changes
Jan 27, 2026
li-em
approved these changes
Jan 27, 2026
icechunk/flatbuffers/repo.fbs
Outdated
| } | ||
| table NewCommitUpdate { | ||
| branch: string (required); | ||
| snap_id: ObjectId12 (required); |
Contributor
There was a problem hiding this comment.
This will touch almost every change in this PR, but... is snapshot_id too long? 😅
Collaborator
Author
There was a problem hiding this comment.
we have snap_id in several places. We should change them all at once in a separate PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an Icechunk 2 on-disk format breaking change.
Closes: #1580