Support async refreshable credential callbacks in Python bindings#1639
Open
mpiannucci wants to merge 17 commits intomainfrom
Open
Support async refreshable credential callbacks in Python bindings#1639mpiannucci wants to merge 17 commits intomainfrom
mpiannucci wants to merge 17 commits intomainfrom
Conversation
mpiannucci
commented
Feb 12, 2026
paraseba
reviewed
Feb 14, 2026
Collaborator
paraseba
left a comment
paraseba
left a comment
There was a problem hiding this comment.
This is a miracle of engineering hehe, I understand little of it, but that's OK. I hope we can make Samantha's tests pass and merge.
| return asyncio.run(coroutine) | ||
| except RuntimeError as err: | ||
| coroutine.close() | ||
| if "asyncio.run() cannot be called from a running event loop" in str(err): |
Collaborator
There was a problem hiding this comment.
Interesting.... this is a bit of a breaking change, because everybody (including Earthmover) uses True for scatter
Collaborator
Author
There was a problem hiding this comment.
I'll think on this..
- When no Python event loop is running, create a persistent fallback loop on a background thread instead of calling asyncio.run() each time (which creates a new temporary loop per invocation). - Detect potential deadlocks when the credential callback targets the same event loop that is currently blocked, and raise an error instead of hanging. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Collaborator
Author
|
This is working well now, but it required adding throwing an exception when calling synbc api from async context I think we need to change this to warn that this is can lead to deadlocks and that in a future version of icechunk this behavior may be disallowed. A good example of the consequence of this is the xarray test failure |
Collaborator
Author
|
@dcherian i dont understand the xarray test suite, do you ahve any context on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for async refreshable credential callbacks in the Python bindings, allowing users to provide async def functions for credential refresh that work correctly across sync and async contexts via pyo3-async-runtimes' TaskLocals bridge.
Closes #1424