Skip bytes logging in object_store

[dcherian]

I used

samply record -- python script.py

I also grepped for write_

-> % grep -B 2 "fn write_" icechunk/src/**/**.rs
icechunk/src/asset_manager.rs-
icechunk/src/asset_manager.rs-    #[instrument(skip(self, manifest))]
icechunk/src/asset_manager.rs:    pub async fn write_manifest(&self, manifest: Arc<Manifest>) -> RepositoryResult<u64> {
--
icechunk/src/asset_manager.rs-
icechunk/src/asset_manager.rs-    #[instrument(skip(self, snapshot))]
icechunk/src/asset_manager.rs:    pub async fn write_snapshot(&self, snapshot: Arc<Snapshot>) -> RepositoryResult<()> {
--
icechunk/src/asset_manager.rs-
icechunk/src/asset_manager.rs-    #[instrument(skip(self, log))]
icechunk/src/asset_manager.rs:    pub async fn write_transaction_log(
--
icechunk/src/asset_manager.rs-
icechunk/src/asset_manager.rs-    #[instrument(skip(self, bytes))]
icechunk/src/asset_manager.rs:    pub async fn write_chunk(
--
icechunk/src/asset_manager.rs-}
icechunk/src/asset_manager.rs-
icechunk/src/asset_manager.rs:async fn write_new_manifest(
--
icechunk/src/asset_manager.rs-}
icechunk/src/asset_manager.rs-
icechunk/src/asset_manager.rs:async fn write_new_snapshot(
--
icechunk/src/asset_manager.rs-}
icechunk/src/asset_manager.rs-
icechunk/src/asset_manager.rs:async fn write_new_tx_log(
--
icechunk/src/cli/interface.rs-}
icechunk/src/cli/interface.rs-
icechunk/src/cli/interface.rs:fn write_config(config: &CliConfig) -> Result<(), anyhow::Error> {
--
icechunk/src/session.rs-    /// Write a manifest for a node that was created in this session
icechunk/src/session.rs-    /// It doesn't need to look at previous manifests because the node is new
icechunk/src/session.rs:    async fn write_manifest_for_new_node(
--
icechunk/src/session.rs-    /// It needs to update the chunks according to the change set
icechunk/src/session.rs-    /// and record the new manifest
icechunk/src/session.rs:    async fn write_manifest_for_existing_node(
--
icechunk/src/storage/logging.rs-    }
icechunk/src/storage/logging.rs-
icechunk/src/storage/logging.rs:    async fn write_snapshot(
--
icechunk/src/storage/logging.rs-    }
icechunk/src/storage/logging.rs-
icechunk/src/storage/logging.rs:    async fn write_transaction_log(
--
icechunk/src/storage/logging.rs-    }
icechunk/src/storage/logging.rs-
icechunk/src/storage/logging.rs:    async fn write_manifest(
--
icechunk/src/storage/logging.rs-    }
icechunk/src/storage/logging.rs-
icechunk/src/storage/logging.rs:    async fn write_chunk(
--
icechunk/src/storage/logging.rs-    }
icechunk/src/storage/logging.rs-
icechunk/src/storage/logging.rs:    async fn write_ref(
--
icechunk/src/storage/mod.rs-    ) -> StorageResult<Box<dyn AsyncRead + Unpin + Send>>;
icechunk/src/storage/mod.rs-
icechunk/src/storage/mod.rs:    async fn write_snapshot(
--
icechunk/src/storage/mod.rs-        bytes: Bytes,
icechunk/src/storage/mod.rs-    ) -> StorageResult<()>;
icechunk/src/storage/mod.rs:    async fn write_manifest(
--
icechunk/src/storage/mod.rs-        bytes: Bytes,
icechunk/src/storage/mod.rs-    ) -> StorageResult<()>;
icechunk/src/storage/mod.rs:    async fn write_chunk(
--
icechunk/src/storage/mod.rs-        bytes: Bytes,
icechunk/src/storage/mod.rs-    ) -> StorageResult<()>;
icechunk/src/storage/mod.rs:    async fn write_transaction_log(
--
icechunk/src/storage/mod.rs-    ) -> StorageResult<GetRefResult>;
icechunk/src/storage/mod.rs-    async fn ref_names(&self, settings: &Settings) -> StorageResult<Vec<String>>;
icechunk/src/storage/mod.rs:    async fn write_ref(
--
icechunk/src/storage/object_store.rs-
icechunk/src/storage/object_store.rs-    #[instrument(skip(self, settings, metadata, bytes))]
icechunk/src/storage/object_store.rs:    async fn write_snapshot(
--
icechunk/src/storage/object_store.rs-
icechunk/src/storage/object_store.rs-    #[instrument(skip(self, settings, metadata, bytes))]
icechunk/src/storage/object_store.rs:    async fn write_manifest(
--
icechunk/src/storage/object_store.rs-
icechunk/src/storage/object_store.rs-    #[instrument(skip(self, settings, metadata, bytes))]
icechunk/src/storage/object_store.rs:    async fn write_transaction_log(
--
icechunk/src/storage/object_store.rs-
icechunk/src/storage/object_store.rs-    #[instrument(skip(self, _settings, bytes))]
icechunk/src/storage/object_store.rs:    async fn write_chunk(
--
icechunk/src/storage/object_store.rs-
icechunk/src/storage/object_store.rs-    #[instrument(skip(self, settings, bytes))]
icechunk/src/storage/object_store.rs:    async fn write_ref(
--
icechunk/src/storage/s3.rs-
icechunk/src/storage/s3.rs-    #[instrument(skip(self, settings, metadata, bytes))]
icechunk/src/storage/s3.rs:    async fn write_snapshot(
--
icechunk/src/storage/s3.rs-
icechunk/src/storage/s3.rs-    #[instrument(skip(self, settings, metadata, bytes))]
icechunk/src/storage/s3.rs:    async fn write_manifest(
--
icechunk/src/storage/s3.rs-
icechunk/src/storage/s3.rs-    #[instrument(skip(self, settings, metadata, bytes))]
icechunk/src/storage/s3.rs:    async fn write_transaction_log(
--
icechunk/src/storage/s3.rs-
icechunk/src/storage/s3.rs-    #[instrument(skip(self, settings, bytes))]
icechunk/src/storage/s3.rs:    async fn write_chunk(
--
icechunk/src/storage/s3.rs-
icechunk/src/storage/s3.rs-    #[instrument(skip(self, settings, bytes))]
icechunk/src/storage/s3.rs:    async fn write_ref(

[paraseba]

Could you grep all instrument calls?

[dcherian]

I didn't spot anything else. I used skip_all where it made sense as a small cleanup.

[paraseba]

amazing