Support changing log levels and setting them in Python#982
Merged
Conversation
This introduces a new function `icechunk.set_logs_filter(str)` that allows setting and changing the logs Icechunk will produce. On module import, we still initialize logs to the value of ICECHUNK_LOG environment variable (or error level if not present).
mpiannucci
approved these changes
Jun 12, 2025
| pub fn initialize_tracing() { | ||
| #[allow(clippy::type_complexity)] | ||
| static LOG_FILTER: std::sync::LazyLock< | ||
| std::sync::Mutex< |
dcherian
reviewed
Jun 12, 2025
| let os = py.import("os")?; | ||
| let environ = os.getattr("environ")?; | ||
| let environ: &Bound<PyMapping> = environ.downcast()?; | ||
| let value = environ.get_item("ICECHUNK_LOG").ok().and_then(|v| v.extract().ok()); |
dcherian
pushed a commit
that referenced
this pull request
Jun 12, 2025
This introduces a new function `icechunk.set_logs_filter(str)` that allows setting and changing the logs Icechunk will produce. On module import, we still initialize logs to the value of ICECHUNK_LOG environment variable (or error level if not present).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a new function
icechunk.set_logs_filter(str)that allows setting and changing the logs Icechunk will produce.On module import, we still initialize logs to the value of ICECHUNK_LOG environment variable (or error level if not present).