Fixups and minor addition to docs homepage - #1089
Merged
Merged
Conversation
|
I will automatically update this comment whenever this PR is modified
|
9 tasks
Co-authored-by: Saber Brasher <134096880+saberbrasher@users.noreply.github.com> Co-authored-by: Julia Stewart Lowndes <5891909+jules32@users.noreply.github.com>
These are not publicly viewable Co-authored-by: Saber Brasher <134096880+saberbrasher@users.noreply.github.com> Co-authored-by: Julia Stewart Lowndes <5891909+jules32@users.noreply.github.com>
Co-authored-by: Julia Stewart Lowndes <5891909+jules32@users.noreply.github.com>
mfisher87
force-pushed
the
docs-homepage-updates
branch
from
September 12, 2025 17:17
b75c93c to
1dee582
Compare
danielfromearth
previously approved these changes
Sep 12, 2025
danielfromearth
left a comment
danielfromearth
left a comment
Contributor
There was a problem hiding this comment.
@mfisher87 looks good! only one hyphen to add 🤏
Co-authored-by: Daniel Kaufman <114174502+danielfromearth@users.noreply.github.com>
Member
Author
|
Since applying @danielfromearth's feedback auto-dismissed his approval, I'm going to consider this approved and bypass merge protections :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@saberbrasher found a couple issues and @jules32 suggested fixes and an addition.
Thanks!
Pull Request (PR) draft checklist - click to expand
contributing documentation
before getting started.
title such as "Add testing details to the contributor section of the README".
Example PRs: #763
example
closes #1. SeeGitHub docs - Linking a pull request to an issue.
CHANGELOG.mdwith details about your change in a section titled## Unreleased. If such a section does not exist, please create one. FollowCommon Changelog for your additions.
Example PRs: #763
README.mdwith details of changes to theearthaccess interface, if any. Consider new environment variables, function names,
decorators, etc.
Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!
Pull Request (PR) merge checklist - click to expand
Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the
@nsidc/earthaccess-supportteam in a comment and wewill help you out!
Request containing "pre-commit.ci autofix" to automate this.
📚 Documentation preview 📚: https://earthaccess--1089.org.readthedocs.build/en/1089/