allow granule_name to be Iterable[str] - #1101
Conversation
|
I will automatically update this comment whenever this PR is modified
|
chuckwondo
left a comment
There was a problem hiding this comment.
Thanks for picking this up!
Co-authored-by: Chuck Daniels <cjdaniels4@gmail.com>
|
Thanks for the suggestions @chuckwondo! |
granule_name to be list[str]granule_name to be Iterable[str]
chuckwondo
left a comment
There was a problem hiding this comment.
Looks good, but I have one minor change request (actually a change to my original suggestion). Also, please remove from Draft mode.
Co-authored-by: Chuck Daniels <cjdaniels4@gmail.com>
|
Looks like there's a ruff formatting issue, as pre-commit.ci failed. If you have |
The above is a good habit, but in case something slips through, it is also possible to fix ruff fixes by adding a comment to the PR with only the following contents in the comment: |
for more information, see https://pre-commit.ci
This allows the
granule_nameparameter to be a list of strings, thereby allowing the search over multiple granule names (e.g. for ICESat-2 multiple RGTs). This works aspython_cmrqueries allow the passing of lists when building the CMR query url.Pull Request (PR) draft checklist - click to expand
contributing documentation
before getting started.
title such as "Add testing details to the contributor section of the README".
Example PRs: #763
example
closes #1. SeeGitHub docs - Linking a pull request to an issue.
CHANGELOG.mdwith details about your change in a section titled## Unreleased. If such a section does not exist, please create one. FollowCommon Changelog for your additions.
Example PRs: #763
README.mdwith details of changes to theearthaccess interface, if any. Consider new environment variables, function names,
decorators, etc.
Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!
Pull Request (PR) merge checklist - click to expand
Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the
@nsidc/earthaccess-supportteam in a comment and wewill help you out!
Request containing "pre-commit.ci autofix" to automate this.
📚 Documentation preview 📚: https://earthaccess--1101.org.readthedocs.build/en/1101/