Skip to content

allow granule_name to be Iterable[str] - #1101

Merged
chuckwondo merged 5 commits into
earthaccess-dev:mainfrom
tsutterley:granule_name
Sep 24, 2025
Merged

allow granule_name to be Iterable[str]#1101
chuckwondo merged 5 commits into
earthaccess-dev:mainfrom
tsutterley:granule_name

Conversation

@tsutterley

@tsutterley tsutterley commented Sep 21, 2025

Copy link
Copy Markdown
Contributor

This allows the granule_name parameter to be a list of strings, thereby allowing the search over multiple granule names (e.g. for ICESat-2 multiple RGTs). This works as python_cmr queries allow the passing of lists when building the CMR query url.

Pull Request (PR) draft checklist - click to expand
  • Please review our
    contributing documentation
    before getting started.
  • Populate a descriptive title. For example, instead of "Updated README.md", use a
    title such as "Add testing details to the contributor section of the README".
    Example PRs: #763
  • Populate the body of the pull request with:
  • Update CHANGELOG.md with details about your change in a section titled
    ## Unreleased. If such a section does not exist, please create one. Follow
    Common Changelog for your additions.
    Example PRs: #763
  • Update the documentation and/or the README.md with details of changes to the
    earthaccess interface, if any. Consider new environment variables, function names,
    decorators, etc.

Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!

Pull Request (PR) merge checklist - click to expand

Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the @nsidc/earthaccess-support team in a comment and we
will help you out!

  • Add unit tests for any new features.
  • Apply formatting and linting autofixes. You can add a GitHub comment in this Pull
    Request containing "pre-commit.ci autofix" to automate this.
  • Ensure all automated PR checks (seen at the bottom of the "conversation" tab) pass.
  • Get at least one approving review.

📚 Documentation preview 📚: https://earthaccess--1101.org.readthedocs.build/en/1101/

@github-actions

github-actions Bot commented Sep 21, 2025

Copy link
Copy Markdown

Binder 👈 Launch a binder notebook on this branch for commit 4fa4030

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 03f638a

Binder 👈 Launch a binder notebook on this branch for commit 0651b53

Binder 👈 Launch a binder notebook on this branch for commit 6b4a433

Binder 👈 Launch a binder notebook on this branch for commit 4c39400

@chuckwondo chuckwondo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up!

Comment thread earthaccess/search.py Outdated
Comment thread earthaccess/search.py Outdated
Comment thread earthaccess/search.py Outdated
tsutterley and others added 2 commits September 22, 2025 16:06
Co-authored-by: Chuck Daniels <cjdaniels4@gmail.com>
@tsutterley

Copy link
Copy Markdown
Contributor Author

Thanks for the suggestions @chuckwondo!

@tsutterley tsutterley changed the title allow granule_name to be list[str] allow granule_name to be Iterable[str] Sep 22, 2025

@chuckwondo chuckwondo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I have one minor change request (actually a change to my original suggestion). Also, please remove from Draft mode.

Comment thread earthaccess/search.py Outdated
Co-authored-by: Chuck Daniels <cjdaniels4@gmail.com>
@tsutterley
tsutterley marked this pull request as ready for review September 24, 2025 20:01
@chuckwondo

Copy link
Copy Markdown
Contributor

Looks like there's a ruff formatting issue, as pre-commit.ci failed. If you have uv installed, run the following:

uv run pre-commit run -a

@chuckwondo

Copy link
Copy Markdown
Contributor

Looks like there's a ruff formatting issue, as pre-commit.ci failed. If you have uv installed, run the following:

uv run pre-commit run -a

The above is a good habit, but in case something slips through, it is also possible to fix ruff fixes by adding a comment to the PR with only the following contents in the comment:

pre-commit.ci autofix

@chuckwondo chuckwondo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tsutterley!

@chuckwondo
chuckwondo merged commit 45728c8 into earthaccess-dev:main Sep 24, 2025
13 of 17 checks passed
@tsutterley
tsutterley deleted the granule_name branch September 24, 2025 21:28
@github-project-automation github-project-automation Bot moved this to ✅ Done in earthaccess Mar 3, 2026
@mfisher87 mfisher87 removed this from earthaccess Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants