Skip to content

Install dev dependencies with dependency groups - #1206

Merged
mfisher87 merged 10 commits into
mainfrom
dependency-groups
Feb 12, 2026
Merged

Install dev dependencies with dependency groups#1206
mfisher87 merged 10 commits into
mainfrom
dependency-groups

Conversation

@mfisher87

@mfisher87 mfisher87 commented Feb 12, 2026

Copy link
Copy Markdown
Member

Move dev dependencies into dependency groups.

This is the correct way to define development dependencies that the end-user would never want to install.

See: https://peps.python.org/pep-0735/

uv will automatically install the dev group with uv sync. And the contributor could also do uv sync --all-groups to be sure they have all possible dev dependencies without needing to read the docs too closely ;)

Pull Request (PR) draft checklist - click to expand
  • Please review our
    contributing documentation
    before getting started.
  • Populate a descriptive title. For example, instead of "Updated README.md", use a
    title such as "Add testing details to the contributor section of the README".
    Example PRs: #763
  • Populate the body of the pull request with:
  • Update CHANGELOG.md with details about your change in a section titled
    ## Unreleased. If such a section does not exist, please create one. Follow
    Common Changelog for your additions.
    Example PRs: #763
  • Update the documentation and/or the README.md with details of changes to the
    earthaccess interface, if any. Consider new environment variables, function names,
    decorators, etc.

Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!

Pull Request (PR) merge checklist - click to expand

Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the @nsidc/earthaccess-support team in a comment and we
will help you out!

  • Add unit tests for any new features.
  • Apply formatting and linting autofixes. You can add a GitHub comment in this Pull
    Request containing "pre-commit.ci autofix" to automate this.
  • Ensure all automated PR checks (seen at the bottom of the "conversation" tab) pass.
  • Get at least one approving review.

@github-actions

github-actions Bot commented Feb 12, 2026

Copy link
Copy Markdown

Binder 👈 Launch a binder notebook on this branch for commit 2d8977c

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit 8610dda

Binder 👈 Launch a binder notebook on this branch for commit 7c56837

Binder 👈 Launch a binder notebook on this branch for commit 5a81774

Binder 👈 Launch a binder notebook on this branch for commit 86f8b54

chuckwondo
chuckwondo previously approved these changes Feb 12, 2026

@chuckwondo chuckwondo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! I was recently discussing with someone about the need for earthaccess to consider making deps more modular so that we can avoid pulling in deps we don't need, so this is a good first step.

I realize you're waiting to merge another PR before this one, but approving this now so you're not blocked.

@mfisher87

Copy link
Copy Markdown
Member Author

Looks like the integration test failures are a result of a change in CMR holdings, not related to this PR. I'll let the tests run again now that I've done conflict resolution then merge!

@mfisher87
mfisher87 merged commit 9fcbb2b into main Feb 12, 2026
8 of 11 checks passed
@mfisher87
mfisher87 deleted the dependency-groups branch February 12, 2026 22:23
@chuckwondo

Copy link
Copy Markdown
Contributor

Looks like the integration test failures are a result of a change in CMR holdings, not related to this PR. I'll let the tests run again now that I've done conflict resolution then merge!

Yep, I just noticed that for another PR as well. I'm looking into the failures, but happy to have your eyes on them too!

@mfisher87

Copy link
Copy Markdown
Member Author

I'm really behind on my TODO list for today but I can help look at it tomorrow or maybe the weekend!

@chuckwondo

Copy link
Copy Markdown
Contributor

I'm really behind on my TODO list for today but I can help look at it tomorrow or maybe the weekend!

No worries. 2-line fix is here, if you want to approve: #1207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants