Install dev dependencies with dependency groups - #1206
Conversation
This is the correct way to define development dependencies that the end-user would never want to install. See: <https://peps.python.org/pep-0735/> `uv` will automatically install the `dev` group with `uv sync`.
|
I will automatically update this comment whenever this PR is modified
|
chuckwondo
left a comment
There was a problem hiding this comment.
Excellent! I was recently discussing with someone about the need for earthaccess to consider making deps more modular so that we can avoid pulling in deps we don't need, so this is a good first step.
I realize you're waiting to merge another PR before this one, but approving this now so you're not blocked.
|
Looks like the integration test failures are a result of a change in CMR holdings, not related to this PR. I'll let the tests run again now that I've done conflict resolution then merge! |
Yep, I just noticed that for another PR as well. I'm looking into the failures, but happy to have your eyes on them too! |
|
I'm really behind on my TODO list for today but I can help look at it tomorrow or maybe the weekend! |
No worries. 2-line fix is here, if you want to approve: #1207 |
Move dev dependencies into dependency groups.
This is the correct way to define development dependencies that the end-user would never want to install.
See: https://peps.python.org/pep-0735/
uvwill automatically install thedevgroup withuv sync. And the contributor could also douv sync --all-groupsto be sure they have all possible dev dependencies without needing to read the docs too closely ;)Pull Request (PR) draft checklist - click to expand
contributing documentation
before getting started.
title such as "Add testing details to the contributor section of the README".
Example PRs: #763
example
closes #1. SeeGitHub docs - Linking a pull request to an issue.
CHANGELOG.mdwith details about your change in a section titled## Unreleased. If such a section does not exist, please create one. FollowCommon Changelog for your additions.
Example PRs: #763
README.mdwith details of changes to theearthaccess interface, if any. Consider new environment variables, function names,
decorators, etc.
Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!
Pull Request (PR) merge checklist - click to expand
Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the
@nsidc/earthaccess-supportteam in a comment and wewill help you out!
Request containing "pre-commit.ci autofix" to automate this.