Skip to content

add a ".binder" folder to support mybinder.org and repo2docker builds - #1245

Merged
itcarroll merged 3 commits into
mainfrom
issue-1244
Mar 4, 2026
Merged

add a ".binder" folder to support mybinder.org and repo2docker builds#1245
itcarroll merged 3 commits into
mainfrom
issue-1244

Conversation

@itcarroll

@itcarroll itcarroll commented Mar 4, 2026

Copy link
Copy Markdown
Contributor

Description

I don't know for how long #1244 has been a problem, but I don't see how the current repository worked with repo2docker and thus with mybinder.org. The docker builds would find the "environment.yml" file, but would not have the source tree and could not use pip install -e.

This PR adds a .binder folder that includes

  1. a "environment.yml" file to constrain the python version. Unfortunately, a minimum version is not recognized by repo2docker, only an explicit version.
  2. a "postBuild" to install the package with pip as advised in Python repo is not built if CondaBuildPack is selected jupyterhub/repo2docker#1265

"Ready for review" checklist

  • Open PR as draft
  • Please review our Pull Request Guide
  • Mark "ready for review" after following instructions in the guide

Merge checklist

  • PR title is descriptive
  • PR body contains links to related and resolved issues (e.g. closes #1)
    - [ ] If needed, CHANGELOG.md updated
    - [ ] If needed, docs and/or README.md updated
    - [ ] If needed, unit tests added
  • All checks passing (comment pre-commit.ci autofix if pre-commit is failing)
  • At least one approval

@itcarroll

Copy link
Copy Markdown
Contributor Author

I confirmed that mybinder.org launch is okay.

@itcarroll
itcarroll marked this pull request as ready for review March 4, 2026 16:19
Comment thread .binder/environment.yml
@itcarroll
itcarroll requested a review from mfisher87 March 4, 2026 16:41
mfisher87
mfisher87 previously approved these changes Mar 4, 2026

@mfisher87 mfisher87 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor suggestion!

Comment thread .binder/postBuild Outdated
@itcarroll

Copy link
Copy Markdown
Contributor Author

Note that I tried to switch the root level "environment.yml" to use --group as well, and it does not work.

Installing pip packages: --group dev, --editable .
Usage: __main__.py [options]

ERROR: Invalid requirement: --group dev
__main__.py: error: no such option: --group

That was with pip 26.0.1.

One more review request coming.

@itcarroll
itcarroll requested a review from mfisher87 March 4, 2026 19:32
@itcarroll
itcarroll enabled auto-merge March 4, 2026 19:37

@chuckwondo chuckwondo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @itcarroll!

@itcarroll
itcarroll merged commit 776cdec into main Mar 4, 2026
7 of 8 checks passed
@itcarroll
itcarroll deleted the issue-1244 branch March 4, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

binder, repo2docker builds failing due to python version and missing source

3 participants