Skip to content

fix(observation): stale Sales Invoice Status on Observation records #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
md-umair-21 wants to merge 1 commit into
base: develop
Choose a base branch
from
+7 −2
Open

fix(observation): stale Sales Invoice Status on Observation records #1066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions healthcare/healthcare/doctype/observation/observation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,11 +393,11 @@
"read_only": 1
},
{
"fetch_from": "sales_invoice.status",
"fieldname": "sales_invoice_status",
"fieldtype": "Data",
"label": "Sales Invoice Status",
"read_only": 1
"read_only": 1,
"is_virtual": 1
},
{
"fieldname": "column_break_zrac",
Expand Down
5 changes: 5 additions & 0 deletions healthcare/healthcare/doctype/observation/observation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@


class Observation(Document):
@property
def sales_invoice_status(self):
if self.sales_invoice:
return frappe.db.get_value("Sales Invoice", self.sales_invoice, "status")

def validate(self):
self.set_age()
self.set_result_time()
Expand Down
Loading