fix: Reload Diagnostic Report after workflow action to resolve unsave…#960
Open
Irfan778899 wants to merge 1 commit into
Conversation
Irfan778899
changed the title
Irfan778899
force-pushed
the
fix_save_diagnostic_report_after_results_approved
branch
from
6292ba9 to
cd5b1a8
Compare
Irfan778899
force-pushed
the
fix_save_diagnostic_report_after_results_approved
branch
from
cd5b1a8 to
a405877
Compare
Contributor
|
@Sajinsr Kindly review this. Long pending. The users often get confused with this state of Not Saved. |
Sajinsr
force-pushed
the
version-16-hotfix
branch
from
8d14c5b to
3937534
Compare
Contributor
|
Thanks for addressing this. May I know when will this be shipped? @Sajinsr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After performing a workflow action (e.g., Approve) on Diagnostic Report,
the backend updates observation status via set_observation_status, but
the form remains in a dirty (unsaved) state in the UI.
This causes the "Not Saved" indicator to appear even though the document
is already updated and shows correct status in list view.
Added frm.reload_doc() after successful workflow action to sync the form
state with backend and clear the false unsaved state.
Also added a safety check before calling save_action in before_save.