Skip to content

Allow more flexibility with SG rules and IAM policies#1

Open
distilledtee wants to merge 6 commits intoearthly:mainfrom
o8t:patches-for-reconciliation
Open

Allow more flexibility with SG rules and IAM policies#1
distilledtee wants to merge 6 commits intoearthly:mainfrom
o8t:patches-for-reconciliation

Conversation

@distilledtee
Copy link

@distilledtee distilledtee commented Sep 27, 2024

This PR contains a few changes to add flexibility in managing the Security Group and Instance Role attached to the satellite instances.

Changes

  • Move Ingress/Egress fields in SG definition to explicit resources
    AWS deprecated the use of the ingress and egress fields in the aws_security_group resource. On the reference page there are both a Warning and Note discussing how the resource configured to use these fields may have issues managing multiple CIDRs and explicitly warns not to use these fields with specific Ingress/Egress rules. Since we want to be able to attach additional rules I've moved the existing rules into specific resources.

  • Added an override variable for SG rule CIDRs
    By default the ingress rules use the subnet's CIDR. In our use case this was too restrictive so I've added a new variable, sg_cidr_override that if specified will be used as the rule's CIDR instead of the subnet's CIDR

  • Changed the instance_profile output to the name instead of ARN
    In order to read an instance_profile as data you need to specify the name of it instead of its ARN. See the data reference page

  • Changed the policy attachment method to an explicit attachment resource
    AWS notes in the aws_iam_role reference that managed_policy_arns is not compatible with aws_iam_role_policy_attachments. Since we're adding additional policies, the module can't use managed_policy_arns

@distilledtee distilledtee reopened this Oct 7, 2024
@distilledtee distilledtee changed the title Update BYOC Module for Current Deployment Allow more flexibility with SG rules and IAM policies Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant