Conversation
gutzbenj
left a comment
gutzbenj
left a comment
There was a problem hiding this comment.
Dear @mspils ,
thanks for working on this!
Just two comments:
- there's some commented out code, could you remove it?
- could there be more "speaking" names for the parameters?
There's also also a test
wetterdienst/tests/test_api.py
Line 107 in f717192
that checks that parameter names are part of the one big enum at
that unifies parameter names across services. Could the parameters fit in there?
| pl.col("station_id"), # .str.strip_chars(" ").str.pad_start(5, "0"), #.cast(str) | ||
| pl.col("start_date"), # .str.to_datetime("%Y%m%d", time_zone="UTC",strict=False), | ||
| pl.col("end_date"), # .str.to_datetime("%Y%m%d", time_zone="UTC",strict=False), | ||
| pl.col("height"), # .str.strip_chars().cast(pl.Float64), | ||
| pl.col("latitude"), # .str.strip_chars().cast(pl.Float64), | ||
| pl.col("longitude"), # .str.strip_chars().cast(pl.Float64), | ||
| "name", | ||
| "state", |
There was a problem hiding this comment.
Please remove commented out code here.
|
Just to clarify:
Currently there DWDDerivedMetaData is also not part of test_metadata_parameter_names. I guess I should change that as well? |
|
@mspils yes, exactly, the idea is to get unified names across the different services. The soil temperature names mostly come from the NOAA metadata. I hope the |
|
The categories of soil/cover types used by the DWD are different from the NOAA, so I had to add new Parameters. I decided to not add separate Parameters for the daily/monthly soil Parameters in most cases, since they are aggregated in the way one would expect: Exception to this is Frost/Thaw depth which I added as max. @gutzbenj I assume documentation is my responsibility? What is your stance on LLM generated stuff? Of course manually checked for correctness. |
|
That sounds great, I'll check the naming! Please go ahead, any documentation is better then no documentation! Update: |
2 participants
Added functionality to access DWD Data under: