Skip to content

Improve error message when no files to copy where found in MakeCp easyblock #3907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Flamefire wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Improve error message when no files to copy where found in MakeCp easyblock #3907

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25ac1ee
Improve error message when no files to copy where found in MakeCp eas…
Flamefire Aug 28, 2025
f2d48a4
Merge branch 'develop' into 20250828162254_new_pr_makecp
Flamefire Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions easybuild/easyblocks/generic/makecp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,14 @@ def install_step(self):

mkdir(target, parents=True)

# first look for files in start dir
search_locations = [('start dir', self.start_dir)]
# use location of first unpacked source file as fallback location
try:
search_locations.append(('unpacked source dir', self.src[0]['finalpath']))
except (IndexError, KeyError):
pass # Ignore if no source or source has not finalpath

for orig_files_spec in files_specs:
if isinstance(orig_files_spec, tuple):
files_spec = orig_files_spec[0]
Expand All @@ -99,21 +107,16 @@ def install_step(self):
files_spec = orig_files_spec
dest = None

# first look for files in start dir
filepaths = glob.glob(os.path.join(self.cfg['start_dir'], files_spec))
tup = (files_spec, self.cfg['start_dir'], filepaths)
self.log.debug("List of files matching '%s' in start dir %s: %s" % tup)

if not filepaths and len(self.src) > 0 and 'finalpath' in self.src[0]:
# use location of first unpacked source file as fallback location
tup = (files_spec, self.cfg['start_dir'])
self.log.warning("No files matching '%s' found in start dir %s" % tup)
filepaths = glob.glob(os.path.join(self.src[0]['finalpath'], files_spec))
self.log.debug("List of files matching '%s' in %s: %s" % (tup + (filepaths,)))
for desc, loc in search_locations:
filepaths = glob.glob(os.path.join(loc, files_spec))
if filepaths:
break
self.log.warning("No files matching '%s' found in %s %s", files_spec, desc, loc)

# there should be at least one match per file spec
if not filepaths:
raise EasyBuildError("No files matching '%s' found anywhere.", files_spec)
raise EasyBuildError("No files matching '%s' found in %s.",
files_spec, ' or '.join(loc[1] for loc in search_locations))

if dest and len(filepaths) != 1:
raise EasyBuildError("When a list with new names has been specified, the original file spec can "
Expand Down