DRAFT: Enable new optional flags for petsc single double precisions#4139
Draft
rreho wants to merge 4 commits into
Draft
DRAFT: Enable new optional flags for petsc single double precisions#4139rreho wants to merge 4 commits into
rreho wants to merge 4 commits into
Conversation
| self.cfg.update( | ||
| 'configopts', | ||
| f'--with-precision={precision}' | ||
| ) |
| 'configopts', | ||
| f'--with-scalar-type={scalar}' | ||
| ) | ||
|
|
|
|
||
| if scalar not in ['real', 'complex']: | ||
| raise EasyBuildError(f"Invalid scalar_type: {scalar}") | ||
|
|
| # ----------------------------- | ||
| # PETSc scientific configuration | ||
| # ----------------------------- | ||
|
|
| deps=["ScaLAPACK"] | ||
| else: | ||
| deps = ["FFTW", "ScaLAPACK"] | ||
|
|
| # FFTW, ScaLAPACK | ||
| deps = ["FFTW", "ScaLAPACK"] | ||
| if precision == 'single': | ||
| deps=["ScaLAPACK"] |
|
|
||
| # FFTW, ScaLAPACK | ||
| deps = ["FFTW", "ScaLAPACK"] | ||
| if precision == 'single': |
Member
|
@rreho If you build with the various options, do you get different library names? It would be great if you do as otherwise there would be a name clash and it wouldn't be possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this commit I added few extra config options to enable real, complex, single and double precision compilation.
We would like to introduce a for loop that compiles in a single run the options alltogether and it's something to do for future work @nicspalla