Skip to content

DRAFT: Enable new optional flags for petsc single double precisions#4139

Draft
rreho wants to merge 4 commits into
easybuilders:developfrom
rreho:develop
Draft

DRAFT: Enable new optional flags for petsc single double precisions#4139
rreho wants to merge 4 commits into
easybuilders:developfrom
rreho:develop

Conversation

@rreho

@rreho rreho commented May 21, 2026

Copy link
Copy Markdown

With this commit I added few extra config options to enable real, complex, single and double precision compilation.
We would like to introduce a for loop that compiles in a single run the options alltogether and it's something to do for future work @nicspalla

self.cfg.update(
'configopts',
f'--with-precision={precision}'
)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace

'configopts',
f'--with-scalar-type={scalar}'
)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line contains whitespace


if scalar not in ['real', 'complex']:
raise EasyBuildError(f"Invalid scalar_type: {scalar}")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line contains whitespace

# -----------------------------
# PETSc scientific configuration
# -----------------------------

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line contains whitespace

deps=["ScaLAPACK"]
else:
deps = ["FFTW", "ScaLAPACK"]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line contains whitespace

# FFTW, ScaLAPACK
deps = ["FFTW", "ScaLAPACK"]
if precision == 'single':
deps=["ScaLAPACK"]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing whitespace around operator


# FFTW, ScaLAPACK
deps = ["FFTW", "ScaLAPACK"]
if precision == 'single':

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace

@ocaisa

ocaisa commented May 22, 2026

Copy link
Copy Markdown
Member

@rreho If you build with the various options, do you get different library names? It would be great if you do as otherwise there would be a name clash and it wouldn't be possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants