Use bounded git rev-list for version detection#4163
Open
pavelToman wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR avoids an unnecessary full Git history traversal during EasyBuild version detection.
Currently the code uses
git rev-list HEADand then only keeps the first returned commit hash. On large repositories or filesystems with slow metadata access, this can make even simple commands likeeb --versionnoticeably slow, becausegit rev-list HEADwalks the full reachable commit history.Since EasyBuild only needs the current
HEADcommit hash here, this PR changes the call to the equivalent of:This preserves the existing GitPython-based implementation and the resulting version string, but avoids traversing more history than needed.
In my local testing on an HPC filesystem, this reduced warm
eb --versionstartup time from many seconds to about 0.5 s, while keeping the same reported EasyBuild version and Git revision hashes.This is the matching change for the same version-detection pattern in easyblocks.
*this PR was created with help of ChatGPT5.5
Framework PR: