Skip to content

don't remove test installdir when --disable-cleanup-tmpdir is set for PythonPackage easyblock - #4208

Open
smoors wants to merge 2 commits into
easybuilders:developfrom
smoors:20260826144115_new_pr_pythonpackage
Open

don't remove test installdir when --disable-cleanup-tmpdir is set for PythonPackage easyblock#4208
smoors wants to merge 2 commits into
easybuilders:developfrom
smoors:20260826144115_new_pr_pythonpackage

Conversation

@smoors

@smoors smoors commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@smoors

smoors commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

@boegelbot please test @ jsc-zen3
EB_ARGS="overpy-0.7-GCCcore-14.2.0.eb"

@boegelbot

Copy link
Copy Markdown

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=4208 EB_ARGS="overpy-0.7-GCCcore-14.2.0.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_4208 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11357

Test results coming soon (I hope)...

Details

- notification for comment with ID 5425755971 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot

Copy link
Copy Markdown

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS overpy-0.7-GCCcore-14.2.0.eb

Build succeeded for 1 out of 1 (total: 1 min 38 secs) (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.8, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.25
See https://gist.github.com/boegelbot/00bf52887e3abfcf659fe71e9eeed16e for a full test report.

@boegel boegel changed the title don't remove test installdir when --disable-cleanup-tmpdir is set for pythonpackage easyblock don't remove test installdir when --disable-cleanup-tmpdir is set for PythonPackage easyblock Aug 26, 2026
@boegel boegel added this to the next release (5.4.1?) milestone Aug 26, 2026

if self.pypkg_test_installdir:
if self.pypkg_test_installdir and build_option('cleanup_tmpdir'):
remove_dir(self.pypkg_test_installdir)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm not even sure we really need to aggressively remove this test install dir at all.

It's done out of abundance of care, so we don't accidentally pick up on it, but I'm not sure how that could happen, it's only passed in the test command being run?

@smoors smoors Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i was just thinking the same.
we can just rely on the cleanup_tmpdir option to clean it up.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in db798d3

@smoors

smoors commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

@boegelbot please test @ jsc-zen3
EB_ARGS="overpy-0.7-GCCcore-14.2.0.eb"

@boegelbot

Copy link
Copy Markdown

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=4208 EB_ARGS="overpy-0.7-GCCcore-14.2.0.eb" EB_CONTAINER= EB_REPO=easybuild-easyblocks EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_4208 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11361

Test results coming soon (I hope)...

Details

- notification for comment with ID 5429558765 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot

Copy link
Copy Markdown

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS overpy-0.7-GCCcore-14.2.0.eb

Build succeeded for 1 out of 1 (total: 1 min 3 secs) (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.8, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.25
See https://gist.github.com/boegelbot/5eb0c07a39af2e85ec6b74cd979f6225 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants