don't remove test installdir when --disable-cleanup-tmpdir is set for PythonPackage easyblock - #4208
Conversation
… pythonpackage easyblock
|
@boegelbot please test @ jsc-zen3 |
|
@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 5425755971 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (total: 1 min 38 secs) (1 easyconfigs in total) |
--disable-cleanup-tmpdir is set for PythonPackage easyblock
|
|
||
| if self.pypkg_test_installdir: | ||
| if self.pypkg_test_installdir and build_option('cleanup_tmpdir'): | ||
| remove_dir(self.pypkg_test_installdir) |
There was a problem hiding this comment.
Hmm, I'm not even sure we really need to aggressively remove this test install dir at all.
It's done out of abundance of care, so we don't accidentally pick up on it, but I'm not sure how that could happen, it's only passed in the test command being run?
There was a problem hiding this comment.
yeah i was just thinking the same.
we can just rely on the cleanup_tmpdir option to clean it up.
|
@boegelbot please test @ jsc-zen3 |
|
@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 5429558765 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (total: 1 min 3 secs) (1 easyconfigs in total) |
(created using
eb --new-pr)