Skip to content

Ensure dependencies libpaths are not baked into binutils's ld #4209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Crivella wants to merge 1 commit into
base: develop
Choose a base branch
from
+12 −1
Open

Ensure dependencies libpaths are not baked into binutils's ld #4209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion easybuild/easyblocks/b/binutils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,18 @@ def configure_step(self):
# this should 'harden' the resulting binutils to bootstrap GCC
# (no trouble when other libstdc++ is build etc)
lib_paths = self.determine_used_library_paths()
self.search_paths = lib_paths.copy()

# Filter out any search paths from dependencies, to avoid baking non-needed libraries into ld
dep_roots = []
for dep in self.cfg.dependencies():
dep_root = get_software_root(dep['name'])
if dep_root:
dep_roots.append(dep_root)

for spath in lib_paths:
if not any(spath.startswith(dep_root) for dep_root in dep_roots):
self.search_paths.append(spath)

if self.toolchain.is_system_toolchain():
# The installed lib dir must come first though to avoid taking system libs over installed ones, see:
# https://github.com/easybuilders/easybuild-easyconfigs/issues/10056
Expand Down