Skip to content

Fix bug in unittest-xml-reporting on Python 3.11+ #22787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Flamefire
Copy link
Contributor

@Flamefire Flamefire commented Apr 23, 2025

(created using eb --new-pr)

During a test on foss/2024a I've seen

File "/lib/python3.12/unittest/runner.py", line 152, in printErrors
self.stream.writeln(f"UNEXPECTED SUCCESS: {self.getDescription(test)}")
^^^^^^^^^^^^^^^^^^^^^^^^^
File "/lib/python3.12/unittest/runner.py", line 50, in getDescription
doc_first_line = test.shortDescription()
^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'tuple' object has no attribute 'shortDescription'

This will be fixed by xmlrunner/unittest-xml-reporting#274 which is not yet merged but looks correct. So I just picked that commit to avoid this in our Python 3.11/3.12 EasyConfigs

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
login3.barnard.hpc.tu-dresden.de - Linux RHEL 8.9 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.17
See https://gist.github.com/Flamefire/3113368a57e62c741effe3073c81ae45 for a full test report.

@Flamefire
Copy link
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
login1.romeo.hpc.tu-dresden.de - Linux Rocky Linux 8.9 (Green Obsidian), x86_64, AMD EPYC 7702 64-Core Processor (zen2), Python 3.8.17
See https://gist.github.com/Flamefire/8764b50efbf3cc0cd303f50536431856 for a full test report.

@boegel boegel added bug fix and removed change labels Apr 23, 2025
@boegel boegel added this to the release after 5.0.0 milestone Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants