Allow the use of extension specific github_account#5121
Open
akesandgren wants to merge 2 commits intoeasybuilders:developfrom
Open
Allow the use of extension specific github_account#5121akesandgren wants to merge 2 commits intoeasybuilders:developfrom
akesandgren wants to merge 2 commits intoeasybuilders:developfrom
Conversation
Makes it possible to use templates like GITHUB_SOURCE in source_urls in extensions
…ramework into allow_ext_specific_github_account
Member
|
@akesandgren Are you sure this is sufficient? |
Contributor
Author
|
Well, it works when I use it. I've only tested having github_account inside an extension, not in ext_options but it should pick it up from there too due to the code that handles ext_options and extensions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it possible to use templates like GITHUB_SOURCE in source_urls in extensions