Sort values for cuda_compute_capabilities templates #5144
Open
Flamefire wants to merge 2 commits intoeasybuilders:developfrom
Open
Sort values for cuda_compute_capabilities templates #5144Flamefire wants to merge 2 commits intoeasybuilders:developfrom
Flamefire wants to merge 2 commits intoeasybuilders:developfrom
Conversation
1 task
There have been instances where the order matters so sort the values. Even if it doesn't solve some issues it will at least be consistent.
Flamefire
force-pushed
the
sort-cuda-ccs
branch
from
813791a to
63e286f
Compare
Flamefire
force-pushed
the
sort-cuda-ccs
branch
from
63e286f to
e72cc62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been instances where the order matters so sort the values.
Even if it doesn't solve some issues it will at least be consistent.
E.g.
--cuda-compute-capabilities=7.5,8.0should be the same as--cuda-compute-capabilities=8.0,7.5This is also important to avoid issues with Blackwell that introduced CUDA CC 10.x which when sorting naively will be incorrectly the "lowest" CC.
See companion PR easybuilders/easybuild-easyblocks#4092