Edit how qt system theme is used#639
Open
HANDZCZ wants to merge 2 commits into
Open
Conversation
Adds background color, overlay text/background color, distinct border for popups Fixes distinct elements of ui window having the same background colors (bars, widgets)
Fixes highlited items not being clearly visible on some themes
HANDZCZ
force-pushed
the
fix-qt-system-theme
branch
from
128b395 to
de578db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edits how qt system theme colors are used.
Tested with multiple dark and light themes, so it looked good, and scrollbars, highlights, and so on are nice and visible.
When I tried to format the code, it reformatted the entire document, so you most likely need to format it using your formatter.