fix(): 支持嵌入 iframe 时通讯 #4584
Merged
fix(): 支持嵌入 iframe 时通讯 #4584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4584 +/- ##
==========================================
- Coverage 93.21% 93.21% -0.01%
==========================================
Files 315 316 +1
Lines 10377 10413 +36
Branches 1982 1991 +9
==========================================
+ Hits 9673 9706 +33
- Misses 432 433 +1
- Partials 272 274 +2
|
qiaofengxi
commented
Dec 23, 2024
| sendUrlChange({ | ||
| url: window.location.href, | ||
| }); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
当跨小产品跳转时，不是路由刷新，而是整个页面刷新，不会被 history.listen 监听到，所以这里也加了发送url-change 的消息
next-core
|
||||||||||||||||||||||||||||
| Project |
next-core
|
| Branch Review |
refs/pull/4584/merge
|
| Run status |
|
| Run duration | 00m 27s |
| Commit |
|
| Committer | jojiang |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
6
|
| View all changes introduced in this branch ↗︎ | |
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
packages/brick-container/src/preview/listen.ts:14
- The use of (window as any).PARENT_ORIGIN_IN_IFRAME is risky as it assumes origin is always defined. If it is not, this will cause an error.
(window as any).PARENT_ORIGIN_IN_IFRAME = origin;
packages/brick-kit/src/core/listen.ts:13
- Remove optional chaining from
data?.urlsincedatais always passed in.
if (window.self !== window.parent && data?.url !== cachedUrl) {
qiaofengxi
force-pushed
the
jojiang/v2
branch
2 times, most recently
from
c09aadc to
0e0fbd9
Compare
weareoutman
previously approved these changes
Dec 24, 2024
qiaofengxi
force-pushed
the
jojiang/v2
branch
from
0e0fbd9 to
46be219
Compare
weareoutman
requested changes
Dec 24, 2024
Refs CD-8866
qiaofengxi
force-pushed
the
jojiang/v2
branch
from
46be219 to
b7b727a
Compare
weareoutman
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs CD-8866
依赖检查
组件之间的依赖声明，是微服务组件架构下的重要信息，请确保其正确性。
请勾选以下两组选项其中之一：
或者：
提交信息检查
Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG，请检查工作内容与提交信息是否相符，并在以下每组选项中都依次确认。
破坏性变更：
feat作为提交类型。BREAKING CHANGE: 你的变更说明。新特性：
feat作为提交类型。问题修复：
fix作为提交类型。杂项工作：
即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动，例如修改注释、测试用例、开发文档等：
chore,docs,test等作为提交类型。