fix(serve): create an http agent that always use IPv4 #4589

weareoutman · 2025-01-03T03:42:37Z

依赖检查

组件之间的依赖声明，是微服务组件架构下的重要信息，请确保其正确性。

请勾选以下两组选项其中之一：

本次 MR 没有使用上游组件（例如框架、后台组件等）的较新版本提供的特性。

或者：

本次 MR 使用了上游组件（例如框架、后台组件等）的较新版本提供的特性。
在对应的文件中更新了该上游组件的依赖版本（或确认了当前声明的依赖版本已包含本次 MR 使用的新特性）。

提交信息检查

Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG，请检查工作内容与提交信息是否相符，并在以下每组选项中都依次确认。

破坏性变更是针对于下游使用者而言，可以通过本次改动对下游使用者的影响来识别变更类型：

下游使用者不做任何改动，仍可以正常工作时，那么它属于普通变更。

反之，下游使用者不做改动就无法正常工作时，那么它属于破坏性变更。

例如，构件修改了一个属性名，小产品 Storyboard 中需要使用新属性名才能工作，那么它就是破坏性变更。
又例如，构件还没有任何下游使用者，那么它的任何变更都是普通变更。

破坏性变更：

⚠️ 本次 MR 包含破坏性变更的提交，请继续确认以下所有选项：
没有更好的兼容方案，必须做破坏性变更。
使用了 feat 作为提交类型。
标注了 BREAKING CHANGE: 你的变更说明。
同时更新了本仓库中所有下游使用者的调用。
同时更新了本仓库中所有下游使用者对该子包的依赖为即将发布的 major 版本。
同时为其它仓库的 Migrating 做好了准备，例如文档或批量改动的方法。
手动验证过破坏性变更在 Migrate 后可以正常工作。
破坏性变更所在的提交没有意外携带其它子包的改动。

新特性：

本次 MR 包含新特性的提交，且该提交不带有破坏性变更，并使用了 feat 作为提交类型。
给新特性添加了单元测试。
手动验证过新特性可以正常工作。

问题修复：

本次 MR 包含问题修复的提交，且该提交不带有新特性或破坏性变更，并使用了 fix 作为提交类型。
给问题修复添加了单元测试。
手动验证过问题修复得到解决。

杂项工作：

即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动，例如修改注释、测试用例、开发文档等：

本次 MR 包含杂项工作的提交，且该提交不带有问题修复、新特性或破坏性变更，并使用了 chore, docs, test 等作为提交类型。

Summary by CodeRabbit

新功能
- 优化代理请求处理逻辑，增强本地开发环境下的网络请求管理。
性能改进
- 改进 HTTP 代理代理设置，增加 IPv4 代理支持。
- 优化请求头处理，特别是 accept-encoding 头部管理。

Copilot

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

cypress · 2025-01-03T03:44:17Z

next-core Run #10861

Run Properties: Passed #10861 • 09cf337668 ℹ️: Merge 0c4dcd6590ecb51f5fb75fcb9ffe6fd28348f5c8 into feb95796f5382da9f7a6b5b46a67...

Project	`next-core`
Branch Review	`steve/v3-fix-proxy`
Run status	`Passed #10861`
Run duration	`00m 22s`
Commit	`09cf337668 ℹ️: Merge 0c4dcd6590ecb51f5fb75fcb9ffe6fd28348f5c8 into feb95796f5382da9f7a6b5b46a67...`
Committer	`Shenwei Wang`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`16`
View all changes introduced in this branch ↗︎

coderabbitai · 2025-01-03T03:45:39Z

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 eslint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/brick-container/serve/getProxy.js

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "@next-core/eslint-config-next" to extend from. Please check that the name of the config is correct.

The config "@next-core/eslint-config-next" was referenced from the config file in "/.eslintrc".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

概述

步骤概述

此更改主要修改了 getProxy.js 文件中的代理请求处理逻辑。新增了对 HTTP 代理代理的处理，通过引入 http 和 https 模块，并定义了一个 getAgent 函数来创建专门配置的 IPv4 HTTP 代理。更新了代理选项生成逻辑，调整了请求头处理，特别是对 origin 和 accept-encoding 头的处理。

变更

文件路径	变更摘要
`packages/brick-container/serve/getProxy.js`	- 新增 `getAgent` 函数，创建 IPv4 HTTP 代理 - 更新 `getBasicProxyOptions` 函数，添加 `agent` 属性 - 修改 `origin` 头重置逻辑 - 调整 `accept-encoding` 头处理，替换 `zstd` 为 `gzip`

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/brick-container/serve/getProxy.js (1)

13-22: 建议在多种协议场景下充分考虑当前 Agent 的复用问题
getAgent 函数只在全局变量 agent 未被定义时才会初始化。如果 server 在不同调用中可能从 http 变为 https，此实现可能会导致后续请求复用已创建的 Agent 而非正确的协议栈。视使用场景而定，建议在需要时根据协议动态创建多个 Agent，或在逻辑上保证 server 不会随时改变协议。

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between feb9579 and 0c4dcd6.

📒 Files selected for processing (1)

packages/brick-container/serve/getProxy.js (4 hunks)

🔇 Additional comments (3)

packages/brick-container/serve/getProxy.js (3)

1-2: 引入 Node.js 原生模块以支持自定义 Agent 的 IPv4 功能
这两行导入 node:http 与 node:https 模块，为后面的自定义 IPv4 Agent 打下基础，没有明显问题。

87-91: 在 Host 为 0.0.0.0 的场景下强制重置 Origin 头部可以防止意外影响
这里新增了当服务器 Host 来源是 0.0.0.0 时强制更新 Origin 的逻辑，有助于统一请求头，避免代理层对本地等测试环境产生误判。此实现看起来逻辑合理。

479-479: 在代理选项中使用 agent 有助于一致地启用 IPv4
通过在返回值中配置 agent 属性，确保了在代理请求时默认使用 IPv4。若将来需要更多参数（如 keepAlive 等），可以进一步扩展此配置。
[approve]

fix(serve): create an http agent that always use IPv4

0c4dcd6

weareoutman added the eve: release after merged label Jan 3, 2025

weareoutman requested a review from Copilot January 3, 2025 03:42

Copilot AI reviewed Jan 3, 2025

View reviewed changes

coderabbitai bot reviewed Jan 3, 2025

View reviewed changes

qiaofengxi approved these changes Jan 3, 2025

View reviewed changes

qiaofengxi merged commit 826f766 into v3 Jan 3, 2025
8 checks passed

qiaofengxi deleted the steve/v3-fix-proxy branch January 3, 2025 03:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(serve): create an http agent that always use IPv4 #4589

fix(serve): create an http agent that always use IPv4 #4589

Uh oh!

weareoutman commented Jan 3, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

cypress bot commented Jan 3, 2025

Uh oh!

coderabbitai bot commented Jan 3, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(serve): create an http agent that always use IPv4 #4589

fix(serve): create an http agent that always use IPv4 #4589

Uh oh!

Conversation

weareoutman commented Jan 3, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

依赖检查

提交信息检查

破坏性变更：

新特性：

问题修复：

杂项工作：

Summary by CodeRabbit

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

cypress bot commented Jan 3, 2025

next-core Run #10861

Uh oh!

coderabbitai bot commented Jan 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

概述

步骤概述

变更

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

weareoutman commented Jan 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)