Skip to content

fix(): refine loading bar custom event #4601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
weareoutman merged 1 commit into from
Jan 23, 2025
Merged

fix(): refine loading bar custom event #4601

weareoutman merged 1 commit into from
Jan 23, 2025

Conversation

@qiaofengxi
Copy link
Contributor

@qiaofengxi qiaofengxi commented Jan 23, 2025 •
edited
Loading

Refs CD-9047

依赖检查

组件之间的依赖声明，是微服务组件架构下的重要信息，请确保其正确性。

请勾选以下两组选项其中之一：

  • 本次 MR 没有使用上游组件（例如框架、后台组件等）的较新版本提供的特性。

或者：

  • 本次 MR 使用了上游组件（例如框架、后台组件等）的较新版本提供的特性。
  • 在对应的文件中更新了该上游组件的依赖版本（或确认了当前声明的依赖版本已包含本次 MR 使用的新特性）。

提交信息检查

Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG，请检查工作内容与提交信息是否相符，并在以下每组选项中都依次确认。

破坏性变更是针对于下游使用者而言，可以通过本次改动对下游使用者的影响来识别变更类型：

  • 下游使用者不做任何改动，仍可以正常工作时，那么它属于普通变更。
  • 反之，下游使用者不做改动就无法正常工作时，那么它属于破坏性变更。

例如，构件修改了一个属性名，小产品 Storyboard 中需要使用新属性名才能工作，那么它就是破坏性变更。
又例如，构件还没有任何下游使用者，那么它的任何变更都是普通变更。

破坏性变更：

  • ⚠️ 本次 MR 包含破坏性变更的提交，请继续确认以下所有选项：
  • 没有更好的兼容方案，必须做破坏性变更。
  • 使用了 feat 作为提交类型。
  • 标注了 BREAKING CHANGE: 你的变更说明。
  • 同时更新了本仓库中所有下游使用者的调用。
  • 同时更新了本仓库中所有下游使用者对该子包的依赖为即将发布的 major 版本。
  • 同时为其它仓库的 Migrating 做好了准备，例如文档或批量改动的方法。
  • 手动验证过破坏性变更在 Migrate 后可以正常工作。
  • 破坏性变更所在的提交没有意外携带其它子包的改动。

新特性：

  • 本次 MR 包含新特性的提交，且该提交不带有破坏性变更，并使用了 feat 作为提交类型。
  • 给新特性添加了单元测试。
  • 手动验证过新特性可以正常工作。

问题修复：

  • 本次 MR 包含问题修复的提交，且该提交不带有新特性或破坏性变更，并使用了 fix 作为提交类型。
  • 给问题修复添加了单元测试。
  • 手动验证过问题修复得到解决。

杂项工作：

即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动，例如修改注释、测试用例、开发文档等：

  • 本次 MR 包含杂项工作的提交，且该提交不带有问题修复、新特性或破坏性变更，并使用了 chore, docs, test 等作为提交类型。

@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cypress
Copy link

cypress bot commented Jan 23, 2025

next-core    Run #10901

Run Properties:  status check passed Passed #10901  •  git commit 579e321473 ℹ️: Merge 05a79815a74ce5ecaebfb8a9e617fa5189a5bd1b into f951fa2997fda87f804538ca5e50...
Project next-core
Branch Review refs/pull/4601/merge
Run status status check passed Passed #10901
Run duration 00m 29s
Commit git commit 579e321473 ℹ️: Merge 05a79815a74ce5ecaebfb8a9e617fa5189a5bd1b into f951fa2997fda87f804538ca5e50...
Committer jojiang
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 6
View all changes introduced in this branch ↗︎

qiaofengxi
qiaofengxi commented Jan 23, 2025
View reviewed changes
packages/brick-container/src/index.tsx
const curWindow = isInSpecialFrame() ? window.parent : window;
curWindow.dispatchEvent(new CustomEvent("request.start"));
window.dispatchEvent(new CustomEvent("request.start"));
}
Copy link
Contributor Author

@qiaofengxi qiaofengxi Jan 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这样修改为了当动态去掉 bars-hidden-in-iframe 类名后，能够在 iframe 正常显示加载条

这里之前做了区分处理，在 iframe 嵌入模式下，只有外层才触发加载条 loading 的事件，iframe 内部应该也可以让其触发，以便能够适配某些场景(qiankun 应用接入我们平台)，由于后面会通过动态添加 bars-hidden-in-iframe 类名的逻辑会使其整体隐藏，所以额外触发的事件应该也没有影响
image

@weareoutman weareoutman merged commit 3277448 into master Jan 23, 2025
9 checks passed
@weareoutman weareoutman deleted the jojiang/v2 branch January 23, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weareoutman weareoutman weareoutman approved these changes

Assignees

No one assigned

Labels

eve: release after merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qiaofengxi @weareoutman