fix(): using batch search contract which has serviceName while single search missing #4750
Conversation
Walkthrough本次变更将 Changes
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/easyops-runtime/src/flowApi/FlowApi.spec.tsOops! Something went wrong! :( ESLint: 9.29.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@next-core/eslint-config-next' imported from /eslint.config.mjs packages/easyops-runtime/src/flowApi/FlowApi.tsOops! Something went wrong! :( ESLint: 9.29.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@next-core/eslint-config-next' imported from /eslint.config.mjs 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
🧰 Additional context used🧬 Code Graph Analysis (1)packages/easyops-runtime/src/flowApi/FlowApi.spec.ts (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (10)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #4750 +/- ##
==========================================
- Coverage 95.22% 95.21% -0.01%
==========================================
Files 209 209
Lines 9144 9151 +7
Branches 1760 1760
==========================================
+ Hits 8707 8713 +6
- Misses 323 324 +1
Partials 114 114
🚀 New features to boost your workflow:
|
next-core
|
||||||||||||||||||||||||||||
| Project |
next-core
|
| Branch Review |
steve/v3-fix-search-contract
|
| Run status |
|
| Run duration | 00m 27s |
| Commit |
|
| Committer | Shenwei Wang |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
17
|
| View all changes introduced in this branch ↗︎ | |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with API contract retrieval by switching from single search to batch search interface. The change addresses missing serviceName in the single search contract method by using the batch search contract API that provides complete contract information.
- Switch from
ContractApi_searchSingleContracttoContractCenterApi_batchSearchContractAPI - Update contract name format from
namespace.nametonamespace@name - Add improved error handling with console logging for failed contract fetches
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/easyops-runtime/src/flowApi/FlowApi.ts | Updated contract fetching logic to use batch search API with enhanced error handling |
| packages/easyops-runtime/src/flowApi/FlowApi.spec.ts | Updated test mocks and expectations to match new batch search API structure |
| packages/easyops-runtime/package.json | Added dependency on @next-api-sdk/next-builder-sdk |
| endpoint: contractData.endpoint, | ||
| response: contractData.response, | ||
| request: contractData.request, | ||
| try { |
There was a problem hiding this comment.
因为依赖 next builder 服务，静默接口错误
依赖检查
组件之间的依赖声明，是微服务组件架构下的重要信息，请确保其正确性。
请勾选以下两组选项其中之一：
或者：
提交信息检查
Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG，请检查工作内容与提交信息是否相符，并在以下每组选项中都依次确认。
破坏性变更：
feat作为提交类型。BREAKING CHANGE: 你的变更说明。新特性：
feat作为提交类型。问题修复：
fix作为提交类型。杂项工作：
即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动，例如修改注释、测试用例、开发文档等：
chore,docs,test等作为提交类型。Summary by CodeRabbit