Skip to content

Conversation

@weareoutman
Copy link
Member

@weareoutman weareoutman commented Sep 25, 2025

依赖检查

组件之间的依赖声明,是微服务组件架构下的重要信息,请确保其正确性。

请勾选以下两组选项其中之一:

  • 本次 MR 没有使用上游组件(例如框架、后台组件等)的较新版本提供的特性。

或者:

  • 本次 MR 使用了上游组件(例如框架、后台组件等)的较新版本提供的特性。
  • 在对应的文件中更新了该上游组件的依赖版本(或确认了当前声明的依赖版本已包含本次 MR 使用的新特性)。

提交信息检查

Git 提交信息将决定包的版本发布及自动生成的 CHANGELOG,请检查工作内容与提交信息是否相符,并在以下每组选项中都依次确认。

破坏性变更是针对于下游使用者而言,可以通过本次改动对下游使用者的影响来识别变更类型:

  • 下游使用者不做任何改动,仍可以正常工作时,那么它属于普通变更。
  • 反之,下游使用者不做改动就无法正常工作时,那么它属于破坏性变更。

例如,构件修改了一个属性名,小产品 Storyboard 中需要使用新属性名才能工作,那么它就是破坏性变更。
又例如,构件还没有任何下游使用者,那么它的任何变更都是普通变更。

破坏性变更:

  • ⚠️ 本次 MR 包含破坏性变更的提交,请继续确认以下所有选项:
  • 没有更好的兼容方案,必须做破坏性变更。
  • 使用了 feat 作为提交类型。
  • 标注了 BREAKING CHANGE: 你的变更说明
  • 同时更新了本仓库中所有下游使用者的调用。
  • 同时更新了本仓库中所有下游使用者对该子包的依赖为即将发布的 major 版本。
  • 同时为其它仓库的 Migrating 做好了准备,例如文档或批量改动的方法。
  • 手动验证过破坏性变更在 Migrate 后可以正常工作。
  • 破坏性变更所在的提交没有意外携带其它子包的改动。

新特性:

  • 本次 MR 包含新特性的提交,且该提交不带有破坏性变更,并使用了 feat 作为提交类型。
  • 给新特性添加了单元测试。
  • 手动验证过新特性可以正常工作。

问题修复:

  • 本次 MR 包含问题修复的提交,且该提交不带有新特性或破坏性变更,并使用了 fix 作为提交类型。
  • 给问题修复添加了单元测试。
  • 手动验证过问题修复得到解决。

杂项工作:

即所有对下游使用者无任何影响、且没有必要显示在 CHANGELOG 中的改动,例如修改注释、测试用例、开发文档等:

  • 本次 MR 包含杂项工作的提交,且该提交不带有问题修复、新特性或破坏性变更,并使用了 chore, docs, test 等作为提交类型。

Summary by CodeRabbit

  • 样式
    • 优化输入框外观:移除内阴影,视觉更干净利落,与整体主题更一致。提升可读性与专注度,避免在浅/深色背景下出现发灰或凹陷感。此改动仅影响视觉呈现,不改变交互行为与布局。

@coderabbitai
Copy link

coderabbitai bot commented Sep 25, 2025

Walkthrough

更新了运行时测试以调整模拟签名与控制台间谍的作用域并新增断言路径;为 customTemplates 增加 clearIsolatedRegistry 公共方法并在测试中调用验证;主题样式中修改了一个 CSS 变量值。

Changes

Cohort / File(s) Summary
Runtime tests: templates
packages/runtime/src/CustomTemplates.spec.ts
将两个 jest mock 改为可接受可选参数的签名;新增调用 customTemplates.clearIsolatedRegistry() 的测试片段,并断言已有模板仍可获取。
Runtime tests: root creation
packages/runtime/src/createRoot.spec.ts
引入按测试用例的 console.error/console.warn 间谍与恢复;新增未知砖块/模板路径的错误断言;在作用域片段模板相关测试中添加警告断言与重定义场景。
Runtime public API
packages/runtime/src/CustomTemplates.js
新增导出方法:customTemplates.clearIsolatedRegistry()
Theme CSS
packages/theme/src/elevo.css
--elevo-input-box-shadowinset 0px -1px 3px 0px rgba(var(--elevo-color-brand-rgb-channel), 0.5) 改为 none

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Description Check ⚠️ Warning PR 描述仅保留了模板表单而未填写任何选项,缺少依赖检查结果、提交信息类型确认、变更简述和 Todo 等关键信息,无法评估本次 MR 的实际内容和影响。 请根据仓库提供的模板完整填写依赖检查和提交信息检查的勾选项,并补充《简单描述》和《Todo》部分,以明确本次 MR 的具体功能改动、测试覆盖和待办事项。
Title Check ❓ Inconclusive 标题“Steve/v3-isolated-templates”仅为分支命名形式,没有说明本次 MR 的具体功能或核心改动,过于通用且无法让审阅者快速理解主要变更。 建议将标题替换为能概括主要改动的简洁短句,例如“新增 clearIsolatedRegistry 接口并完善 CustomTemplates 测试”,以便于快速了解 MR 内容。
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch steve/v3-isolated-templates

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 0c0367f and 1cd3f42.

📒 Files selected for processing (3)
  • packages/runtime/src/CustomTemplates.spec.ts (2 hunks)
  • packages/runtime/src/createRoot.spec.ts (5 hunks)
  • packages/theme/src/elevo.css (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build (20.x)
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (3)
packages/runtime/src/CustomTemplates.spec.ts (1)

330-333: 👍 针对非隔离注册表的验证很到位

这段测试确保清理隔离注册表不会误伤常规模板,能及时捕获实现上的回归,补充得很好。

packages/runtime/src/createRoot.spec.ts (1)

354-418: 逐测监控控制台输出的处理很干净

console.warn 采用用例内的 spy 并在末尾恢复,既避免了串测污染,也精准验证了模板重定义的告警行为,处理得当。

packages/theme/src/elevo.css (1)

14-14: 输入组件阴影设为 none 与设计稿一致
参照最新视觉稿,移除 inset 内阴影是预期的统一化调整,这里没有发现问题。

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.21%. Comparing base (0c0367f) to head (1cd3f42).
⚠️ Report is 3 commits behind head on v3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##               v3    #4797      +/-   ##
==========================================
+ Coverage   95.19%   95.21%   +0.02%     
==========================================
  Files         212      212              
  Lines        9301     9301              
  Branches     1785     1785              
==========================================
+ Hits         8854     8856       +2     
  Misses        327      327              
+ Partials      120      118       -2     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress
Copy link

cypress bot commented Sep 25, 2025

next-core    Run #11696

Run Properties:  status check passed Passed #11696  •  git commit 7b8a239eab ℹ️: Merge 1cd3f4207caa2ac98f753f8fae544cd808bed8c7 into 0c0367f0a0712113ee5b8cd87e75...
Project next-core
Branch Review steve/v3-isolated-templates
Run status status check passed Passed #11696
Run duration 00m 23s
Commit git commit 7b8a239eab ℹ️: Merge 1cd3f4207caa2ac98f753f8fae544cd808bed8c7 into 0c0367f0a0712113ee5b8cd87e75...
Committer Shenwei Wang
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 17
View all changes introduced in this branch ↗︎

@weareoutman weareoutman merged commit ee26b6f into v3 Sep 25, 2025
9 checks passed
@weareoutman weareoutman deleted the steve/v3-isolated-templates branch September 25, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants