Test on marginaleffects-dev #733
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @strengejacke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the bayestestR package version and adds remote dependencies to facilitate testing or integration with the marginaleffects and insight packages. This prepares the package for development against these external libraries.
Highlights
- Package Version Update: The bayestestR package version has been incremented from 0.16.1.3 to 0.16.1.4.
- Remote Dependencies Added: New remote dependencies for easystats/insight and vincentarelbundock/marginaleffects have been added to the DESCRIPTION file, indicating integration or testing against development versions of these packages.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the package version and adds development versions of insight and marginaleffects to the Remotes field in the DESCRIPTION file, likely for testing purposes. While this works, I've added a comment suggesting a more robust approach for handling development dependencies in CI to avoid potential issues with future CRAN submissions.
|
Oh oops Thanks Daniel! |
|
Don't worry, that was/ is a breaking change in the forthcoming marginaleffects version, to make accessing attributes more robust |
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request updates the package to support upcoming changes in the marginaleffects package, primarily by adapting to its new API for handling posterior draws and refactoring some internal helper functions. The tests are also updated to reflect these changes. I've identified a critical issue where an incorrect variable is used, which would cause a runtime error. I've also suggested a minor formatting fix in a test file to improve readability. Once these points are addressed, the changes look good.
No description provided.