-
-
Notifications
You must be signed in to change notification settings - Fork 61
Test on fixed format_table()
#734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @strengejacke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily updates the package version in the DESCRIPTION file from 0.16.1.4 to 0.16.1.5. While the PR title suggests a test on a fixed format_table() function, the provided patch only shows this version bump. It is likely that the actual code changes related to format_table() or its tests are part of a separate commit or were not included in the provided patch context. This version increment typically indicates preparation for a new release or a minor update following internal changes.
Highlights
- Version Update: The package version in the
DESCRIPTIONfile has been incremented from0.16.1.4to0.16.1.5.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request increments the package version in the DESCRIPTION file. My review focuses on whether the version bump is appropriate given the changes listed in the NEWS.md file for the upcoming release. I've suggested that a minor version bump might be more suitable than a patch bump, due to the inclusion of new features and the removal of a deprecated function.
| Package: bayestestR | ||
| Title: Understand and Describe Bayesian Models and Posterior Distributions | ||
| Version: 0.16.1.4 | ||
| Version: 0.16.1.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the changes for this release as noted in NEWS.md (e.g., new features in rope() and display(), and the removal of the deprecated rnorm_perfect() function), a patch version bump from 0.16.1.4 to 0.16.1.5 might not fully capture the scope of the changes. According to semantic versioning principles, adding new features and introducing breaking changes (even for deprecated functions) typically warrants a minor version increase (e.g., to 0.16.2). This helps to clearly communicate the nature of the update to users.
No description provided.