-
-
Notifications
You must be signed in to change notification settings - Fork 61
Fix verbose parameter not being passed to insight::get_parameters() #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_ci.R and rope.R Co-authored-by: IndrajeetPatil <[email protected]>
….R, and ci.R Co-authored-by: IndrajeetPatil <[email protected]>
Co-authored-by: IndrajeetPatil <[email protected]>
Copilot
AI
changed the title
[WIP] Consistently pass verbose to underlying method
Fix verbose parameter not being passed to insight::get_parameters()
Nov 16, 2025
Copilot finished work on behalf of
IndrajeetPatil
November 16, 2025 15:13
IndrajeetPatil
approved these changes
Nov 16, 2025
Member
|
To keep the diff small in this feature PR, I am ignoring all suggestions related to formatting changes, which should be done in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
verboseparameter was not being passed toinsight::get_parameters()in multiple functions, causing unwanted warnings to propagate to downstream packages like{statsExpressions}even whenverbose = FALSEwas set.Proposed Changes
Added
verbose = verboseparameter toinsight::get_parameters()calls in 32 locations across 10 files where the calling function accepts averboseparameter:.compute_interval_simMerMod(),.compute_interval_sim()inutils_hdi_ci.Rhdi.*(),eti.*(),bci.*(),spi.*(),ci.*()methods for bamlss, bcplm, emmGrid, stanreg, brmsfit modelsrope.*()andp_rope.*()methods for emmGrid, BFBayesFactor, bcplm, stanreg, brmsfit, sim, sim.merMod modelsequivalence_test.emmGrid(),si.stanfit()Example change:
This ensures warning suppression works consistently across the package when users set
verbose = FALSE.Original prompt
verboseto the underlying method #743💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.