Skip to content

Using method = "auto" fails if there is missing data due to the type checking #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhorzek wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Using method = "auto" fails if there is missing data due to the type checking #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d2ac7a
Allow for NA in data when checking the data type
jhorzek Jan 5, 2026
d96ad3e
Added test for missing data when using method = "auto"
jhorzek Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/utils_find_correlationtype.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
out$is_continuous <- TRUE
}

if (all(x %% 1 == 0)) {
if (any(!is.na(x)) && all(x %% 1 == 0, na.rm = TRUE)) {

Check warning on line 60 in R/utils_find_correlationtype.R

View workflow job for this annotation

GitHub Actions / lint-changed-files / lint-changed-files 

file=R/utils_find_correlationtype.R,line=60,col=7,[outer_negation_linter] !all(x) is better than any(!x). The former applies negation only once after aggregation instead of many times for each element of x.
out$is_count <- TRUE
}

Expand Down
17 changes: 17 additions & 0 deletions tests/testthat/test-cor_pairwise_complete_with_NA.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
test_that("pairwise complete correlation with missing data works", {
set.seed(345345)
data_set <- data.frame(
a = sample(c(NA, 1:5), 1000, replace = TRUE),
b = sample(c(NA, 1:5), 1000, replace = TRUE)
)

expected_cor <- cor(data_set, use = "pairwise.complete.obs")

got_cor <- correlation::correlation(
data = data_set,
method = "auto",
missing = "keep_pairwise"
)

testthat::expect_equal(got_cor$r, expected_cor[1, 2])

Check warning on line 16 in tests/testthat/test-cor_pairwise_complete_with_NA.R

View workflow job for this annotation

GitHub Actions / lint-changed-files / lint-changed-files 

file=tests/testthat/test-cor_pairwise_complete_with_NA.R,line=16,col=3,[expect_identical_linter] Use expect_identical(x, y) by default; resort to expect_equal() only when needed, e.g. when setting ignore_attr= or tolerance=.
})
Loading