Cmdstanr methods#1187
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for CmdStanFit models by implementing find_algorithm(), find_parameters(), and get_parameters() methods. The review identifies a bug in chain calculation within find_algorithm(), recommends removing commented-out code for better maintainability, and suggests removing the insight:: prefix from internal function calls to maintain consistency across the codebase.
Member
|
No, I don't think we need tests |
Member
Author
|
As far as I can see failing tests are unrelated to this PR. If you agree, @strengejacke , please merge (: |
Member
|
Thanks, lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1185 #1186
@strengejacke not sure how / if we need to add tests given that
cmdstanrisn't on CRAN (on purpose).