-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check which dev-package are required #257
Conversation
So I wait |
Yes, we need to submit datawizard next (i.e. now 😄) @etiennebacher |
datawizard will also break other packages (well, not break in terms of no longer working, but just deprecation warnings). This was my reply to the "we found rev-dep issues":
|
I'm running revdepcheck and will submit when it's done |
|
I submitted to win-builder. I don't think we need another package on CRAN before submitting modelbased, so once win-builder checks are ok, we can submit. |
Any insights from win-builder? @DominiqueMakowski? |
I assume this warning issue is the same: library(easystats)
#> # Attaching packages: easystats 0.7.2
#> ✔ bayestestR 0.13.2 ✔ correlation 0.8.4
#> ✔ datawizard 0.11.0 ✔ effectsize 0.8.8
#> ✔ insight 0.20.0 ✔ modelbased 0.8.7
#> ✔ performance 0.11.0 ✔ parameters 0.21.7
#> ✔ report 0.5.8 ✔ see 0.8.4 m <- aov(Sepal.Length ~ Species, data = iris)
estimate_means(m, at = "Species")
#> Warning: Argument `at` is deprecated and will be removed in a future release.
#> Please use `by` instead.
#> Estimated Marginal Means
#>
#> Species | Mean | SE | 95% CI
#> ---------------------------------------
#> setosa | 5.01 | 0.07 | [4.86, 5.15]
#> versicolor | 5.94 | 0.07 | [5.79, 6.08]
#> virginica | 6.59 | 0.07 | [6.44, 6.73]
#>
#> Marginal means estimated at Species estimate_means(m, by = "Species")
#> We selected `at = c("Species")`.
#> Warning: Argument `at` is deprecated and will be removed in a future release.
#> Please use `by` instead.
#> Estimated Marginal Means
#>
#> Species | Mean | SE | 95% CI
#> ---------------------------------------
#> setosa | 5.01 | 0.07 | [4.86, 5.15]
#> versicolor | 5.94 | 0.07 | [5.79, 6.08]
#> virginica | 6.59 | 0.07 | [6.44, 6.73]
#>
#> Marginal means estimated at Species Created on 2024-06-08 with reprex v2.1.0 |
Yes. After the update round, all warnings should be silenced. And, the funcions' argument names will be more consistent :-) (except |
I am preparing slides for my annual R workshops. Should I teach |
Depends on whether your workshop starts, and whether your students/attendees have the latest package versions installed ;-) We have on CRAN already: insight, datawizard The new argument we now use across functions/packages is |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
=======================================
Coverage 36.39% 36.39%
=======================================
Files 25 25
Lines 1220 1220
=======================================
Hits 444 444
Misses 776 776 ☔ View full report in Codecov by Sentry. |
insight is on CRAN and breaks modelbased. This PR removes all dev-packages from the REMOTES field, to check which of those packages are required to be on CRAN first, before we submit modelbased.