Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R2 incorrect for methods that use update(model, ~1) and have missing data #804

Merged
merged 9 commits into from
Mar 21, 2025
Merged

R2 incorrect for methods that use update(model, ~1) and have missing data #804

merged 9 commits into from
Mar 21, 2025

Conversation

strengejacke
Copy link
Member

Fixes #803

@strengejacke
Copy link
Member Author

Tests in McFadden fail.
We need to extract data from env, not model frame, then filter for complete cases (only data for model predictors). passing model-frame to update() doesn't work with variables like y / 10 etc.

@strengejacke strengejacke merged commit 3886b63 into main Mar 21, 2025
17 of 33 checks passed
@strengejacke strengejacke deleted the strengejacke/issue803 branch March 21, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

R2 incorrect for methods that use update(model, ~1) and have missing data
1 participant
@strengejacke