Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: report
Type: Package
Title: Automated Reporting of Results and Statistical Models
Version: 0.6.3
Version: 0.6.3.1
Authors@R:
c(person(given = "Dominique",
family = "Makowski",
Expand Down
6 changes: 6 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# report (devel)

Bug fixes

* Fix `report()` crash when character vector has only one unique value (#578).

# report 0.6.3

Bug fixes
Expand Down
9 changes: 6 additions & 3 deletions R/report.character.R
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ report_table.character <- function(
levels_percentage <- .report_dataframe_percentage(x, levels_percentage)
missing_percentage <- .report_dataframe_percentage(x, missing_percentage)

n_char <- as.data.frame(sort(table(x), decreasing = TRUE))
n_char <- as.data.frame(table(x))
n_char <- n_char[order(n_char$Freq, decreasing = TRUE), ]
names(n_char) <- c("Entry", "n_Entry")
n_char$percentage_Entry <- n_char$n_Entry / length(x)

Expand Down Expand Up @@ -105,7 +106,8 @@ report_parameters.character <- function(
param_text <- paste0(entries$Entry, " (n = ", entries$n_Entry, ")")
}

as.report_parameters(param_text, summary = param_text[1:n_entries], ...)
n_entries_actual <- min(n_entries, length(param_text))
as.report_parameters(param_text, summary = param_text[1:n_entries_actual], ...)
Comment thread
strengejacke marked this conversation as resolved.
}


Expand Down Expand Up @@ -243,8 +245,9 @@ report_statistics.character <- function(
stat_text <- paste0(entries$Entry, ", n = ", entries$n_Entry)
}

n_entries_actual <- min(n_entries, length(stat_text))
as.report_statistics(
paste(stat_text, collapse = "; "),
summary = paste(stat_text[1:n_entries], collapse = "; ")
summary = paste(stat_text[1:n_entries_actual], collapse = "; ")
)
Comment thread
strengejacke marked this conversation as resolved.
}
5 changes: 4 additions & 1 deletion R/report_parameters.R
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,8 @@ print.report_parameters <- function(x, ...) {
only_when_insufficient = FALSE,
...
) {
# init
convergence <- stability <- NULL
# Convergence
if ("Rhat" %in% names(diagnostic)) {
convergence <- effectsize::interpret_rhat(diagnostic$Rhat, ...)
Expand Down Expand Up @@ -292,7 +294,8 @@ print.report_parameters <- function(x, ...) {

if (only_when_insufficient) {
ifelse(
convergence != "converged" | stability != "sufficient",
!identical(convergence, "converged") |
!identical(stability, "sufficient"),
text_output,
""
)
Expand Down
3 changes: 1 addition & 2 deletions tests/testthat/_snaps/windows/report.data.frame.md
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,7 @@
range: [8, 896], Skewness = 4.45, Kurtosis = 20.59, 44 missing
- sex: 4 entries, such as male (n = 60); female (n = 16); none (n = 6) and 1
other (4 missing)
- gender: 2 entries, such as masculine (n = 66); feminine (n = 17); NA (4
missing)
- gender: 2 entries, such as masculine (n = 66); feminine (n = 17) (4 missing)
- homeworld: 48 entries, such as Naboo (n = 11); Tatooine (n = 10); Alderaan (n
= 3) and 45 others (10 missing)
- species: 37 entries, such as Human (n = 35); Droid (n = 6); Gungan (n = 3)
Expand Down
31 changes: 31 additions & 0 deletions tests/testthat/test-report_basic_methods.R
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,37 @@ test_that("report.character() respects parameters", {
expect_match(as.character(result3), "n =")
})

test_that("report.character() handles single unique value", {
# Test with a single unique value
single_char <- "big"
result <- report(single_char)

expect_s3_class(result, "report")
expect_match(as.character(result), "1 entry")
expect_match(as.character(result), "big")
expect_no_match(as.character(result), "NA")

# Test with single unique value repeated multiple times
single_repeated <- c("big", "big", "big", "big")
result2 <- report(single_repeated)

expect_s3_class(result2, "report")
expect_match(as.character(result2), "1 entry")
expect_match(as.character(result2), "big")
expect_match(as.character(result2), "n = 4")

# Test in data frame context (original issue)
df <- data.frame(id = 1:6, size = single_char)
result3 <- report(df)

expect_s3_class(result3, "report")
expect_match(as.character(result3), "size")
expect_match(as.character(result3), "big")
Comment thread
strengejacke marked this conversation as resolved.
expect_match(as.character(result3), "1 entry")
expect_match(as.character(result3), "n = 6")
expect_no_match(as.character(result3), "NA")
})

test_that("report.factor() works correctly", {
# Test basic factor
factor_data <- factor(c("low", "medium", "high", "low", "medium", "high"))
Expand Down
Loading