Skip to content

Force LF line endings for R files in .gitattributes - #604

Merged
rempsyc merged 3 commits into
mainfrom
data_tabulate_CRAN_fix
May 4, 2026
Merged

Force LF line endings for R files in .gitattributes#604
rempsyc merged 3 commits into
mainfrom
data_tabulate_CRAN_fix

Conversation

@rempsyc

@rempsyc rempsyc commented May 4, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 4, 2026 14:48

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates project configuration files by adding .positai and .claude to .Rbuildignore, enforcing LF line endings for R files in .gitattributes to support the air formatter, and adding .positai to .gitignore. A review comment correctly points out that .claude should also be added to .gitignore for consistency with the build ignore list and to prevent accidental commits.

Comment thread .gitignore
docs
*.tar.gz
report.Rcheck
.positai

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The file .claude was added to .Rbuildignore but is missing from .gitignore. It should be added here as well to ensure it is not accidentally committed to the repository, maintaining consistency with the addition of .positai.

.positai
.claude

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates repository configuration to ensure consistent LF line endings for R source files (to align with the air formatter expectations) and to exclude local tool configuration files from package builds and/or git tracking.

Changes:

  • Enforce LF line endings for *.R via .gitattributes.
  • Exclude .positai and .claude from R package builds via .Rbuildignore.
  • Ignore .positai in git via .gitignore.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
.Rbuildignore Adds build-exclusion patterns for .positai and .claude.
.gitignore Prevents committing .positai to the repository.
.gitattributes Forces LF EOL for *.R files to avoid CRLF-related formatter issues.

@rempsyc rempsyc closed this May 4, 2026
@rempsyc rempsyc reopened this May 4, 2026
@rempsyc
rempsyc merged commit 158701e into main May 4, 2026
27 of 28 checks passed
@rempsyc
rempsyc deleted the data_tabulate_CRAN_fix branch May 4, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants