fakecgo: move setg and call5 out of autogenerated files #378
+14
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmuntal
changed the title
Collaborator
|
Hmm I'm not sure how I feel about it. The way fakecgo is written is to mimick the structure of runtime/cgo. go_utils is gcc_utils.c in the runtime so that changes can easily be kept in sync. Since these functions aren't found in the original code I put them in the generated file. I'm not fully opposed to it if we don't care to be exactly the same as the runtime. |
Contributor
Author
|
I can put them in a separate file which would contain functions that don't appear upstream, if you wish. |
Collaborator
|
I don't necessarily like the idea of adding another file to hold just two functions. What do you suggest it be called? |
Contributor
Author
|
|
Contributor
Author
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this addressing?
Updates #343
What type of issue is this addressing?
Refactor
What this PR does | solves
setg_trampolineandcall5function signatures don't need to live in autogenerated files, as they don't depend on any input fromgen.go.This will make future enchancements to autogenerated code a bit easier.