Skip to content

fakecgo: don't overwrite the caller stack on arm64 trampolines #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hajimehoshi merged 3 commits into from
Dec 18, 2025
+2 −6
Merged

fakecgo: don't overwrite the caller stack on arm64 trampolines #379

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c57017b
remove unnecessary stack variables
qmuntal Dec 17, 2025
a621e61
undo amd64
qmuntal Dec 17, 2025
0217f74
improve comments
qmuntal Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions internal/fakecgo/trampolines_arm64.s
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,32 +7,28 @@
#include "go_asm.h"
#include "abi_arm64.h"

// these trampolines map the gcc ABI to Go ABI and then calls into the Go equivalent functions.
// These trampolines map the gcc ABI to Go ABIInternal and then calls into the Go equivalent functions.
// Note that C arguments are passed in R0-R7, which matches Go ABIInternal for the first eight arguments.

TEXT x_cgo_init_trampoline(SB), NOSPLIT, $0-0
MOVD R0, 8(RSP)
MOVD R1, 16(RSP)
MOVD ·x_cgo_init_call(SB), R26
MOVD (R26), R2
CALL (R2)
RET

TEXT x_cgo_thread_start_trampoline(SB), NOSPLIT, $0-0
MOVD R0, 8(RSP)
MOVD ·x_cgo_thread_start_call(SB), R26
MOVD (R26), R2
CALL (R2)
RET

TEXT x_cgo_setenv_trampoline(SB), NOSPLIT, $0-0
MOVD R0, 8(RSP)
MOVD ·x_cgo_setenv_call(SB), R26
MOVD (R26), R2
CALL (R2)
RET

TEXT x_cgo_unsetenv_trampoline(SB), NOSPLIT, $0-0
MOVD R0, 8(RSP)
MOVD ·x_cgo_unsetenv_call(SB), R26
MOVD (R26), R2
CALL (R2)
Expand Down