Remove unnecessary RET instruction #380
Merged
+0
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
TotallyGamerJet
left a comment
TotallyGamerJet
left a comment
There was a problem hiding this comment.
I'm okay with removing the RETs but I think keeping the NOFRAME is helpful since without it you need intimate knowledge of Go's assembler to know there is no frame added. I for sure didn't know that
Contributor
Author
|
I have a personal crusade against NOFRAME, as it breaks stack unwinding. The NOFRAMEs in here are no-op, so they don't hurt, but I'm sure someone will copy this code for other purposes and will carry over the NOFRAME, because why not? Anyway, I also see your point. Will add the NOFRAME back. |
hajimehoshi
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this addressing?
Updates #343
What type of issue is this addressing?
Refactor
What this PR does | solves
A function called using a
JMPinstruction doesn't return to the instruction that follows theJMP, but to theJMPparent frame. This means that there is no need to follow that instruction with aRET, it will not be reached. Also, the Go assembler is smart enough to not add function frame when the function doesn't containCALLinstructions, so we don't need to mark them asNOFRAME.