Refactor and fix unit tests for InstallRuleInstaller #1744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally fix an issue where the test checked existence of a
`_state/${pkg.getName()}.yml` file, which doesn't exist as the real
name of the file is `_state/${pkg.getName()}-state.yml` The tests
never caught this as the .expect() wasn't chained with .toBeTruthy() .
Basically this just tests for BepInEx config so the code could've been made even more reusable but the current implememtation retains the option to vary the tested paths by game.
Generic in this context means the test cases don't depend on the actual install rules of any game.
This dummy game is no longer available when the Thunderstore ecosystem schema acts as the source of truth for available games. SUBDIR_NO_FLATTEN tracking method has some generic tests in Installer.Tests.spec.ts so dropping them shouldn't affect test coverage.
anttimaki
force-pushed
the
ei-installer-tests
branch
from
ee09410 to
d52fff4
Compare
VilppeRiskidev
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.