Improve COMPU-RATIONAL-COEFFS scaling robustness#887
Merged
ebroecker merged 1 commit intoDec 10, 2025
Merged
Conversation
Enhance the decode_compu_method function to handle edge cases and comply with AUTOSAR specifications: - Add null safety checks for numerator/denominator parents - Default missing denominator to 1 per AUTOSAR spec - Detect and warn about polynomial scaling (unsupported) - Handle constant mappings (single coefficient) - Handle empty coefficient lists gracefully - Catch IndexError and InvalidOperation in addition to DivisionByZero - Improve warning messages with actual coefficient values for debugging This prevents crashes when parsing ARXML files with malformed or edge-case COMPU-RATIONAL-COEFFS definitions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the decode_compu_method function to handle edge cases and comply with AUTOSAR specifications:
This prevents crashes when parsing ARXML files with malformed or edge-case COMPU-RATIONAL-COEFFS definitions.