Workaround normalisation enabled during render #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having normalisation enabled during render will cause render to fail, since it does a multiple pass.
The fix currently implemented for v1.2 does not actually disable Normalisation if it was previously enabled. It seems that unchecking the normalisation checkbox (in later versions of REAPER ~v7.34) does not actually stop normalisation happening. We only seem to set the visual appearance of the checkbox. We must simulate a click to fire any listeners attached to the checkbox.
We still need a solution for previous versions of REAPER which do not have this checkbox. Normalisation is configured in a separate window, so we can't realistically control that. The best solution is probably just to show an error that render will fail due to normalisation being enabled.